Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Elongate PCB support #8419

Merged
merged 17 commits into from
May 6, 2020
Merged

Add Elongate PCB support #8419

merged 17 commits into from
May 6, 2020

Conversation

Gondolindrim
Copy link
Contributor

Description

This PR adds compatibility to the ElongatePCB pre-Revision Beta and revision Beta, both being identical.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@Gondolindrim Gondolindrim mentioned this pull request Mar 14, 2020
Merged
7 tasks
zvecr
zvecr requested changes Mar 14, 2020
View reviewed changes
keyboards/acheron/elongate/elongate.c Outdated Show resolved Hide resolved
keyboards/acheron/elongate/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/acheron/elongate/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/acheron/elongate/readme.md Outdated Show resolved Hide resolved
keyboards/acheron/elongate/readme.md Outdated Show resolved Hide resolved
keyboards/acheron/elongate/rules.mk Outdated Show resolved Hide resolved
@zvecr zvecr added the keyboard label Mar 14, 2020
@zvecr zvecr requested a review from a team March 14, 2020 18:25
@zvecr
Copy link
Member

zvecr commented Mar 14, 2020

Also, the via keymap is failing to build.

fauxpark
fauxpark requested changes Mar 14, 2020
View reviewed changes
keyboards/acheron/elongate/config.h Outdated Show resolved Hide resolved
keyboards/acheron/elongate/elongate.c Outdated Show resolved Hide resolved
keyboards/acheron/elongate/keymaps/default/config.h Outdated Show resolved Hide resolved
keyboards/acheron/elongate/info.json Show resolved Hide resolved
keyboards/acheron/elongate/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/acheron/elongate/keymaps/via/elongate.c Outdated Show resolved Hide resolved
keyboards/acheron/elongate/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/acheron/elongate/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/baguette/baguette.h Outdated Show resolved Hide resolved
keyboards/projectkb/alice/alice.h Outdated Show resolved Hide resolved
Gondolindrim and others added 8 commits March 15, 2020 06:31
@Gondolindrim @fauxpark @zvecr
Apply suggestions from code review
6ac1638 
Removed redundant comments and fixed typos

Co-Authored-By: Ryan <[email protected]>
Co-Authored-By: Joel Challis <[email protected]>
@Gondolindrim
Delete useless config.h
71064a0 
As per code review
@Gondolindrim
Delete elongate.c
1cd2e2e 
As per code review
@Gondolindrim
Updated readme.md
e1bd122
@Gondolindrim @fauxpark
Update keyboards/acheron/elongate/keymaps/default/keymap.c
7f70535 
As per code review

Co-Authored-By: Ryan <[email protected]>
@Gondolindrim @fauxpark
Apply suggestions from code review
9c9e1b3 
Removed RGB_MODE_TEST definition and substituted for RGB_M_T

Co-Authored-By: Ryan <[email protected]>
@Gondolindrim @fauxpark
Apply suggestions from code review
5f6ac1a 
Reverted changes to alice.h

Co-Authored-By: Ryan <[email protected]>
@Gondolindrim
Update info.json
7752136
fauxpark
fauxpark requested changes Mar 15, 2020
View reviewed changes
keyboards/acheron/elongate/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/acheron/elongate/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/acheron/elongate/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/acheron/elongate/rules.mk Show resolved Hide resolved
Gondolindrim
Gondolindrim commented Mar 18, 2020
View reviewed changes
Copy link
Contributor Author

@Gondolindrim Gondolindrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes submitted to commit 3301fda . Now the VIA keymap is compiling. However I needed to flag MOUSEKEY_ENABLE=no and LINK_TIME_OPTIMIZATN_ENABLE=yes in rules.mk because without both the firmware size extrapolates maximum allowed.

@Gondolindrim
Copy link
Contributor Author

Also, the via keymap is failing to build.

Builds fine now

@Gondolindrim Gondolindrim requested review from zvecr and fauxpark March 20, 2020 13:17
@stale
Copy link

stale bot commented May 5, 2020

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@stale stale bot removed the awaiting changes label May 6, 2020
fauxpark
fauxpark requested changes May 6, 2020
View reviewed changes
keyboards/acheron/elongate/keymaps/via/rules.mk Outdated Show resolved Hide resolved
keyboards/acheron/elongate/config.h Outdated Show resolved Hide resolved
keyboards/acheron/elongate/rules.mk Show resolved Hide resolved
keyboards/acheron/elongate/rules.mk Outdated Show resolved Hide resolved
@zvecr zvecr merged commit b18c261 into qmk:master May 6, 2020
@Gondolindrim Gondolindrim deleted the elongate branch May 6, 2020 16:23
brandonschlack pushed a commit to brandonschlack/qmk_firmware that referenced this pull request May 7, 2020
@Gondolindrim @fauxpark
@zvecr @brandonschlack
Add Elongate PCB support (qmk#8419)
fcabf8e 
* Working on proto

* Start adding VIA support

* Apply suggestions from code review

Removed redundant comments and fixed typos

Co-Authored-By: Ryan <[email protected]>
Co-Authored-By: Joel Challis <[email protected]>

* Delete useless config.h

As per code review

* Delete elongate.c

As per code review

* Updated readme.md

* Update keyboards/acheron/elongate/keymaps/default/keymap.c

As per code review

Co-Authored-By: Ryan <[email protected]>

* Apply suggestions from code review

Removed RGB_MODE_TEST definition and substituted for RGB_M_T

Co-Authored-By: Ryan <[email protected]>

* Apply suggestions from code review

Reverted changes to alice.h

Co-Authored-By: Ryan <[email protected]>

* Update info.json

* Update via/keymap.c

Co-Authored-By: Ryan <[email protected]>

* Solve compiling issue for via keymap

* Add botmagic support and remoce console_enable

Co-Authored-By: Joel Challis <[email protected]>

* Update keyboards/acheron/elongate/rules.mk

Co-authored-by: Ryan <[email protected]>

* Update keyboards/acheron/elongate/keymaps/via/rules.mk

Co-authored-by: Ryan <[email protected]>

* Update keyboards/acheron/elongate/rules.mk

Co-authored-by: Ryan <[email protected]>

* Update keyboards/acheron/elongate/config.h

Co-authored-by: Ryan <[email protected]>

Co-authored-by: Gondolindrim <[email protected]>
Co-authored-by: Ryan <[email protected]>
Co-authored-by: Joel Challis <[email protected]>
bitherder pushed a commit to bitherder/qmk_firmware that referenced this pull request May 15, 2020
@Gondolindrim @fauxpark
@zvecr @lorenzoernesto
Add Elongate PCB support (qmk#8419)
7154a26 
* Working on proto

* Start adding VIA support

* Apply suggestions from code review

Removed redundant comments and fixed typos

Co-Authored-By: Ryan <[email protected]>
Co-Authored-By: Joel Challis <[email protected]>

* Delete useless config.h

As per code review

* Delete elongate.c

As per code review

* Updated readme.md

* Update keyboards/acheron/elongate/keymaps/default/keymap.c

As per code review

Co-Authored-By: Ryan <[email protected]>

* Apply suggestions from code review

Removed RGB_MODE_TEST definition and substituted for RGB_M_T

Co-Authored-By: Ryan <[email protected]>

* Apply suggestions from code review

Reverted changes to alice.h

Co-Authored-By: Ryan <[email protected]>

* Update info.json

* Update via/keymap.c

Co-Authored-By: Ryan <[email protected]>

* Solve compiling issue for via keymap

* Add botmagic support and remoce console_enable

Co-Authored-By: Joel Challis <[email protected]>

* Update keyboards/acheron/elongate/rules.mk

Co-authored-by: Ryan <[email protected]>

* Update keyboards/acheron/elongate/keymaps/via/rules.mk

Co-authored-by: Ryan <[email protected]>

* Update keyboards/acheron/elongate/rules.mk

Co-authored-by: Ryan <[email protected]>

* Update keyboards/acheron/elongate/config.h

Co-authored-by: Ryan <[email protected]>

Co-authored-by: Gondolindrim <[email protected]>
Co-authored-by: Ryan <[email protected]>
Co-authored-by: Joel Challis <[email protected]>
sowbug pushed a commit to sowbug/qmk_firmware that referenced this pull request May 24, 2020
@Gondolindrim @fauxpark
@zvecr @sowbug
Add Elongate PCB support (qmk#8419)
442b927 
* Working on proto

* Start adding VIA support

* Apply suggestions from code review

Removed redundant comments and fixed typos

Co-Authored-By: Ryan <[email protected]>
Co-Authored-By: Joel Challis <[email protected]>

* Delete useless config.h

As per code review

* Delete elongate.c

As per code review

* Updated readme.md

* Update keyboards/acheron/elongate/keymaps/default/keymap.c

As per code review

Co-Authored-By: Ryan <[email protected]>

* Apply suggestions from code review

Removed RGB_MODE_TEST definition and substituted for RGB_M_T

Co-Authored-By: Ryan <[email protected]>

* Apply suggestions from code review

Reverted changes to alice.h

Co-Authored-By: Ryan <[email protected]>

* Update info.json

* Update via/keymap.c

Co-Authored-By: Ryan <[email protected]>

* Solve compiling issue for via keymap

* Add botmagic support and remoce console_enable

Co-Authored-By: Joel Challis <[email protected]>

* Update keyboards/acheron/elongate/rules.mk

Co-authored-by: Ryan <[email protected]>

* Update keyboards/acheron/elongate/keymaps/via/rules.mk

Co-authored-by: Ryan <[email protected]>

* Update keyboards/acheron/elongate/rules.mk

Co-authored-by: Ryan <[email protected]>

* Update keyboards/acheron/elongate/config.h

Co-authored-by: Ryan <[email protected]>

Co-authored-by: Gondolindrim <[email protected]>
Co-authored-by: Ryan <[email protected]>
Co-authored-by: Joel Challis <[email protected]>
turky pushed a commit to turky/qmk_firmware that referenced this pull request Jun 13, 2020
@Gondolindrim @fauxpark
@zvecr @turky
Add Elongate PCB support (qmk#8419)
0f334ed 
* Working on proto

* Start adding VIA support

* Apply suggestions from code review

Removed redundant comments and fixed typos

Co-Authored-By: Ryan <[email protected]>
Co-Authored-By: Joel Challis <[email protected]>

* Delete useless config.h

As per code review

* Delete elongate.c

As per code review

* Updated readme.md

* Update keyboards/acheron/elongate/keymaps/default/keymap.c

As per code review

Co-Authored-By: Ryan <[email protected]>

* Apply suggestions from code review

Removed RGB_MODE_TEST definition and substituted for RGB_M_T

Co-Authored-By: Ryan <[email protected]>

* Apply suggestions from code review

Reverted changes to alice.h

Co-Authored-By: Ryan <[email protected]>

* Update info.json

* Update via/keymap.c

Co-Authored-By: Ryan <[email protected]>

* Solve compiling issue for via keymap

* Add botmagic support and remoce console_enable

Co-Authored-By: Joel Challis <[email protected]>

* Update keyboards/acheron/elongate/rules.mk

Co-authored-by: Ryan <[email protected]>

* Update keyboards/acheron/elongate/keymaps/via/rules.mk

Co-authored-by: Ryan <[email protected]>

* Update keyboards/acheron/elongate/rules.mk

Co-authored-by: Ryan <[email protected]>

* Update keyboards/acheron/elongate/config.h

Co-authored-by: Ryan <[email protected]>

Co-authored-by: Gondolindrim <[email protected]>
Co-authored-by: Ryan <[email protected]>
Co-authored-by: Joel Challis <[email protected]>
jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020
@Gondolindrim @fauxpark
@zvecr @jakobaa
Add Elongate PCB support (qmk#8419)
c89b0aa 
* Working on proto

* Start adding VIA support

* Apply suggestions from code review

Removed redundant comments and fixed typos

Co-Authored-By: Ryan <[email protected]>
Co-Authored-By: Joel Challis <[email protected]>

* Delete useless config.h

As per code review

* Delete elongate.c

As per code review

* Updated readme.md

* Update keyboards/acheron/elongate/keymaps/default/keymap.c

As per code review

Co-Authored-By: Ryan <[email protected]>

* Apply suggestions from code review

Removed RGB_MODE_TEST definition and substituted for RGB_M_T

Co-Authored-By: Ryan <[email protected]>

* Apply suggestions from code review

Reverted changes to alice.h

Co-Authored-By: Ryan <[email protected]>

* Update info.json

* Update via/keymap.c

Co-Authored-By: Ryan <[email protected]>

* Solve compiling issue for via keymap

* Add botmagic support and remoce console_enable

Co-Authored-By: Joel Challis <[email protected]>

* Update keyboards/acheron/elongate/rules.mk

Co-authored-by: Ryan <[email protected]>

* Update keyboards/acheron/elongate/keymaps/via/rules.mk

Co-authored-by: Ryan <[email protected]>

* Update keyboards/acheron/elongate/rules.mk

Co-authored-by: Ryan <[email protected]>

* Update keyboards/acheron/elongate/config.h

Co-authored-by: Ryan <[email protected]>

Co-authored-by: Gondolindrim <[email protected]>
Co-authored-by: Ryan <[email protected]>
Co-authored-by: Joel Challis <[email protected]>
sjmacneil pushed a commit to sjmacneil/qmk_firmware that referenced this pull request Feb 19, 2021
@Gondolindrim @fauxpark
@zvecr @sjmacneil
Add Elongate PCB support (qmk#8419)
55f5627 
* Working on proto

* Start adding VIA support

* Apply suggestions from code review

Removed redundant comments and fixed typos

Co-Authored-By: Ryan <[email protected]>
Co-Authored-By: Joel Challis <[email protected]>

* Delete useless config.h

As per code review

* Delete elongate.c

As per code review

* Updated readme.md

* Update keyboards/acheron/elongate/keymaps/default/keymap.c

As per code review

Co-Authored-By: Ryan <[email protected]>

* Apply suggestions from code review

Removed RGB_MODE_TEST definition and substituted for RGB_M_T

Co-Authored-By: Ryan <[email protected]>

* Apply suggestions from code review

Reverted changes to alice.h

Co-Authored-By: Ryan <[email protected]>

* Update info.json

* Update via/keymap.c

Co-Authored-By: Ryan <[email protected]>

* Solve compiling issue for via keymap

* Add botmagic support and remoce console_enable

Co-Authored-By: Joel Challis <[email protected]>

* Update keyboards/acheron/elongate/rules.mk

Co-authored-by: Ryan <[email protected]>

* Update keyboards/acheron/elongate/keymaps/via/rules.mk

Co-authored-by: Ryan <[email protected]>

* Update keyboards/acheron/elongate/rules.mk

Co-authored-by: Ryan <[email protected]>

* Update keyboards/acheron/elongate/config.h

Co-authored-by: Ryan <[email protected]>

Co-authored-by: Gondolindrim <[email protected]>
Co-authored-by: Ryan <[email protected]>
Co-authored-by: Joel Challis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

@ridingqwerty ridingqwerty ridingqwerty approved these changes

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Gondolindrim @zvecr @drashna @fauxpark @ridingqwerty