-
-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kc60se style, fix or disable broken features #8171
Conversation
Co-Authored-By: James Young <[email protected]>
Co-Authored-By: James Young <[email protected]>
Co-Authored-By: James Young <[email protected]>
Co-Authored-By: James Young <[email protected]>
Co-Authored-By: James Young <[email protected]>
Co-Authored-By: James Young <[email protected]>
Co-Authored-By: James Young <[email protected]>
Co-Authored-By: James Young <[email protected]>
Co-Authored-By: James Young <[email protected]>
Co-Authored-By: James Young <[email protected]>
Co-Authored-By: James Young <[email protected]>
not ready, I need to get a few iso characters corrected
not ready, need to get a few iso character define correctly
Bspc to Backspace
Co-Authored-By: James Young <[email protected]>
Co-Authored-By: James Young <[email protected]>
Co-Authored-By: James Young <[email protected]>
Co-Authored-By: James Young <[email protected]>
Co-Authored-By: James Young <[email protected]>
Co-Authored-By: James Young <[email protected]>
Co-Authored-By: James Young <[email protected]>
Co-Authored-By: James Young <[email protected]>
I feel like I have learned a bit about what you guys want. |
I had commented FORCE_NKRO out.. WHy did it com back?
I think it is good to go, if drashna is good with bl toggle in kc60se.c. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
cool! |
* coding style cleanup, enable/disable misconfigured/broken features * add SCLN missing, compile with backlight PWM warning * edit json * new info.json from KLE * new info.json from KLE using QMK converter * changes notes * notes in pull request * missing line in comments * line wrap * Update keyboards/kc60se/config.h Co-Authored-By: James Young <[email protected]> * Update keyboards/kc60se/keymaps/default/keymap.c Co-Authored-By: James Young <[email protected]> * Update keyboards/kc60se/readme.md Co-Authored-By: James Young <[email protected]> * Update keyboards/kc60se/readme.md Co-Authored-By: James Young <[email protected]> * Update keyboards/kc60se/readme.md Co-Authored-By: James Young <[email protected]> * Update keyboards/kc60se/kc60se.h Co-Authored-By: James Young <[email protected]> * Update keyboards/kc60se/rules.mk Co-Authored-By: James Young <[email protected]> * Update keyboards/kc60se/info.json Co-Authored-By: James Young <[email protected]> * Update keyboards/kc60se/readme.md Co-Authored-By: James Young <[email protected]> * Update keyboards/kc60se/readme.md Co-Authored-By: James Young <[email protected]> * Update keyboards/kc60se/readme.md Co-Authored-By: James Young <[email protected]> * comment back in rules.mk * add 2 iso layouts and keymaps, 1 ansi kemap, compiled and tested * keymaps and info * Delete keymap.c not ready, I need to get a few iso characters corrected * Delete keymap.c not ready, need to get a few iso character define correctly * Update info.json Bspc to Backspace * no unicode * gui_on and gui_off in readme * Update keyboards/kc60se/rules.mk Co-Authored-By: fauxpark <[email protected]> * remove is_command * Update keyboards/kc60se/config.h remove comment Co-Authored-By: fauxpark <[email protected]> * Update keyboards/kc60se/config.h Co-Authored-By: fauxpark <[email protected]> * Update keyboards/kc60se/readme.md Co-Authored-By: fauxpark <[email protected]> * remove \\ in keymaps * Update keyboards/kc60se/info.json Co-Authored-By: James Young <[email protected]> * Update keyboards/kc60se/info.json Co-Authored-By: James Young <[email protected]> * Update keyboards/kc60se/info.json Co-Authored-By: James Young <[email protected]> * Update keyboards/kc60se/info.json Co-Authored-By: James Young <[email protected]> * Update keyboards/kc60se/kc60se.h Co-Authored-By: James Young <[email protected]> * Update keyboards/kc60se/kc60se.h Co-Authored-By: James Young <[email protected]> * Update keyboards/kc60se/kc60se.h Co-Authored-By: James Young <[email protected]> * Update keyboards/kc60se/kc60se.h Co-Authored-By: James Young <[email protected]> * Update keyboards/kc60se/info.json Co-Authored-By: James Young <[email protected]> * set led pin b2 to output mode in matrix_init_kb(), toggle it in led_update_kb() * Update config.h I had commented FORCE_NKRO out.. WHy did it com back? Co-authored-by: Check your git settings! <chris@chris-laptop> Co-authored-by: James Young <[email protected]> Co-authored-by: Ryan <[email protected]>
* upstream/master: (330 commits) Add Danish keymap and sendstring LUT (qmk#8218) format code according to conventions [skip ci] uart.c fix from TMK (qmk#7628) S75 Encoder Fixes (qmk#7758) Add Turkish keymap aliases and sendstring LUT (qmk#7676) Add Arm Teensys to mcu_selection.mk (qmk#8026) [New keyboard]silverbullet44 (qmk#7950) Allow 30us matrix delay to be keyboard/user overridable (qmk#8216) Merge /prime_l and /prime_l_v2 (qmk#8194) [Keymap] Keymap for XD75 with 7U spacebar EN-RU gamers (qmk#8184) Add VIA support for kbd8x mk2 (qmk#8168) Move Grave/Tilde and some lesser used keys on my ergo boards (qmk#8200) [Keyboard] KC60SE cleanup (qmk#8171) Made windows driver installation accept y as All to allow CI (qmk#8189) Change the image photo of /keyboards/reviung41/readme.md (qmk#8195) MxSS RGB Handler Touchup (qmk#8105) Centromere Configurator layout support and readme update (qmk#8190) dynamic keymap sanity check (qmk#8181) [keyboard] Austin (qmk#8176) Use pathlib everywhere we can (qmk#7872) ...
* coding style cleanup, enable/disable misconfigured/broken features * add SCLN missing, compile with backlight PWM warning * edit json * new info.json from KLE * new info.json from KLE using QMK converter * changes notes * notes in pull request * missing line in comments * line wrap * Update keyboards/kc60se/config.h Co-Authored-By: James Young <[email protected]> * Update keyboards/kc60se/keymaps/default/keymap.c Co-Authored-By: James Young <[email protected]> * Update keyboards/kc60se/readme.md Co-Authored-By: James Young <[email protected]> * Update keyboards/kc60se/readme.md Co-Authored-By: James Young <[email protected]> * Update keyboards/kc60se/readme.md Co-Authored-By: James Young <[email protected]> * Update keyboards/kc60se/kc60se.h Co-Authored-By: James Young <[email protected]> * Update keyboards/kc60se/rules.mk Co-Authored-By: James Young <[email protected]> * Update keyboards/kc60se/info.json Co-Authored-By: James Young <[email protected]> * Update keyboards/kc60se/readme.md Co-Authored-By: James Young <[email protected]> * Update keyboards/kc60se/readme.md Co-Authored-By: James Young <[email protected]> * Update keyboards/kc60se/readme.md Co-Authored-By: James Young <[email protected]> * comment back in rules.mk * add 2 iso layouts and keymaps, 1 ansi kemap, compiled and tested * keymaps and info * Delete keymap.c not ready, I need to get a few iso characters corrected * Delete keymap.c not ready, need to get a few iso character define correctly * Update info.json Bspc to Backspace * no unicode * gui_on and gui_off in readme * Update keyboards/kc60se/rules.mk Co-Authored-By: fauxpark <[email protected]> * remove is_command * Update keyboards/kc60se/config.h remove comment Co-Authored-By: fauxpark <[email protected]> * Update keyboards/kc60se/config.h Co-Authored-By: fauxpark <[email protected]> * Update keyboards/kc60se/readme.md Co-Authored-By: fauxpark <[email protected]> * remove \\ in keymaps * Update keyboards/kc60se/info.json Co-Authored-By: James Young <[email protected]> * Update keyboards/kc60se/info.json Co-Authored-By: James Young <[email protected]> * Update keyboards/kc60se/info.json Co-Authored-By: James Young <[email protected]> * Update keyboards/kc60se/info.json Co-Authored-By: James Young <[email protected]> * Update keyboards/kc60se/kc60se.h Co-Authored-By: James Young <[email protected]> * Update keyboards/kc60se/kc60se.h Co-Authored-By: James Young <[email protected]> * Update keyboards/kc60se/kc60se.h Co-Authored-By: James Young <[email protected]> * Update keyboards/kc60se/kc60se.h Co-Authored-By: James Young <[email protected]> * Update keyboards/kc60se/info.json Co-Authored-By: James Young <[email protected]> * set led pin b2 to output mode in matrix_init_kb(), toggle it in led_update_kb() * Update config.h I had commented FORCE_NKRO out.. WHy did it com back? Co-authored-by: Check your git settings! <chris@chris-laptop> Co-authored-by: James Young <[email protected]> Co-authored-by: Ryan <[email protected]>
* 'master' of https://github.com/nesth/qmk_firmware: (331 commits) helix like crkbd Add Danish keymap and sendstring LUT (qmk#8218) format code according to conventions [skip ci] uart.c fix from TMK (qmk#7628) S75 Encoder Fixes (qmk#7758) Add Turkish keymap aliases and sendstring LUT (qmk#7676) Add Arm Teensys to mcu_selection.mk (qmk#8026) [New keyboard]silverbullet44 (qmk#7950) Allow 30us matrix delay to be keyboard/user overridable (qmk#8216) Merge /prime_l and /prime_l_v2 (qmk#8194) [Keymap] Keymap for XD75 with 7U spacebar EN-RU gamers (qmk#8184) Add VIA support for kbd8x mk2 (qmk#8168) Move Grave/Tilde and some lesser used keys on my ergo boards (qmk#8200) [Keyboard] KC60SE cleanup (qmk#8171) Made windows driver installation accept y as All to allow CI (qmk#8189) Change the image photo of /keyboards/reviung41/readme.md (qmk#8195) MxSS RGB Handler Touchup (qmk#8105) Centromere Configurator layout support and readme update (qmk#8190) dynamic keymap sanity check (qmk#8181) [keyboard] Austin (qmk#8176) ...
* coding style cleanup, enable/disable misconfigured/broken features * add SCLN missing, compile with backlight PWM warning * edit json * new info.json from KLE * new info.json from KLE using QMK converter * changes notes * notes in pull request * missing line in comments * line wrap * Update keyboards/kc60se/config.h Co-Authored-By: James Young <[email protected]> * Update keyboards/kc60se/keymaps/default/keymap.c Co-Authored-By: James Young <[email protected]> * Update keyboards/kc60se/readme.md Co-Authored-By: James Young <[email protected]> * Update keyboards/kc60se/readme.md Co-Authored-By: James Young <[email protected]> * Update keyboards/kc60se/readme.md Co-Authored-By: James Young <[email protected]> * Update keyboards/kc60se/kc60se.h Co-Authored-By: James Young <[email protected]> * Update keyboards/kc60se/rules.mk Co-Authored-By: James Young <[email protected]> * Update keyboards/kc60se/info.json Co-Authored-By: James Young <[email protected]> * Update keyboards/kc60se/readme.md Co-Authored-By: James Young <[email protected]> * Update keyboards/kc60se/readme.md Co-Authored-By: James Young <[email protected]> * Update keyboards/kc60se/readme.md Co-Authored-By: James Young <[email protected]> * comment back in rules.mk * add 2 iso layouts and keymaps, 1 ansi kemap, compiled and tested * keymaps and info * Delete keymap.c not ready, I need to get a few iso characters corrected * Delete keymap.c not ready, need to get a few iso character define correctly * Update info.json Bspc to Backspace * no unicode * gui_on and gui_off in readme * Update keyboards/kc60se/rules.mk Co-Authored-By: fauxpark <[email protected]> * remove is_command * Update keyboards/kc60se/config.h remove comment Co-Authored-By: fauxpark <[email protected]> * Update keyboards/kc60se/config.h Co-Authored-By: fauxpark <[email protected]> * Update keyboards/kc60se/readme.md Co-Authored-By: fauxpark <[email protected]> * remove \\ in keymaps * Update keyboards/kc60se/info.json Co-Authored-By: James Young <[email protected]> * Update keyboards/kc60se/info.json Co-Authored-By: James Young <[email protected]> * Update keyboards/kc60se/info.json Co-Authored-By: James Young <[email protected]> * Update keyboards/kc60se/info.json Co-Authored-By: James Young <[email protected]> * Update keyboards/kc60se/kc60se.h Co-Authored-By: James Young <[email protected]> * Update keyboards/kc60se/kc60se.h Co-Authored-By: James Young <[email protected]> * Update keyboards/kc60se/kc60se.h Co-Authored-By: James Young <[email protected]> * Update keyboards/kc60se/kc60se.h Co-Authored-By: James Young <[email protected]> * Update keyboards/kc60se/info.json Co-Authored-By: James Young <[email protected]> * set led pin b2 to output mode in matrix_init_kb(), toggle it in led_update_kb() * Update config.h I had commented FORCE_NKRO out.. WHy did it com back? Co-authored-by: Check your git settings! <chris@chris-laptop> Co-authored-by: James Young <[email protected]> Co-authored-by: Ryan <[email protected]>
* coding style cleanup, enable/disable misconfigured/broken features * add SCLN missing, compile with backlight PWM warning * edit json * new info.json from KLE * new info.json from KLE using QMK converter * changes notes * notes in pull request * missing line in comments * line wrap * Update keyboards/kc60se/config.h Co-Authored-By: James Young <[email protected]> * Update keyboards/kc60se/keymaps/default/keymap.c Co-Authored-By: James Young <[email protected]> * Update keyboards/kc60se/readme.md Co-Authored-By: James Young <[email protected]> * Update keyboards/kc60se/readme.md Co-Authored-By: James Young <[email protected]> * Update keyboards/kc60se/readme.md Co-Authored-By: James Young <[email protected]> * Update keyboards/kc60se/kc60se.h Co-Authored-By: James Young <[email protected]> * Update keyboards/kc60se/rules.mk Co-Authored-By: James Young <[email protected]> * Update keyboards/kc60se/info.json Co-Authored-By: James Young <[email protected]> * Update keyboards/kc60se/readme.md Co-Authored-By: James Young <[email protected]> * Update keyboards/kc60se/readme.md Co-Authored-By: James Young <[email protected]> * Update keyboards/kc60se/readme.md Co-Authored-By: James Young <[email protected]> * comment back in rules.mk * add 2 iso layouts and keymaps, 1 ansi kemap, compiled and tested * keymaps and info * Delete keymap.c not ready, I need to get a few iso characters corrected * Delete keymap.c not ready, need to get a few iso character define correctly * Update info.json Bspc to Backspace * no unicode * gui_on and gui_off in readme * Update keyboards/kc60se/rules.mk Co-Authored-By: fauxpark <[email protected]> * remove is_command * Update keyboards/kc60se/config.h remove comment Co-Authored-By: fauxpark <[email protected]> * Update keyboards/kc60se/config.h Co-Authored-By: fauxpark <[email protected]> * Update keyboards/kc60se/readme.md Co-Authored-By: fauxpark <[email protected]> * remove \\ in keymaps * Update keyboards/kc60se/info.json Co-Authored-By: James Young <[email protected]> * Update keyboards/kc60se/info.json Co-Authored-By: James Young <[email protected]> * Update keyboards/kc60se/info.json Co-Authored-By: James Young <[email protected]> * Update keyboards/kc60se/info.json Co-Authored-By: James Young <[email protected]> * Update keyboards/kc60se/kc60se.h Co-Authored-By: James Young <[email protected]> * Update keyboards/kc60se/kc60se.h Co-Authored-By: James Young <[email protected]> * Update keyboards/kc60se/kc60se.h Co-Authored-By: James Young <[email protected]> * Update keyboards/kc60se/kc60se.h Co-Authored-By: James Young <[email protected]> * Update keyboards/kc60se/info.json Co-Authored-By: James Young <[email protected]> * set led pin b2 to output mode in matrix_init_kb(), toggle it in led_update_kb() * Update config.h I had commented FORCE_NKRO out.. WHy did it com back? Co-authored-by: Check your git settings! <chris@chris-laptop> Co-authored-by: James Young <[email protected]> Co-authored-by: Ryan <[email protected]>
* coding style cleanup, enable/disable misconfigured/broken features * add SCLN missing, compile with backlight PWM warning * edit json * new info.json from KLE * new info.json from KLE using QMK converter * changes notes * notes in pull request * missing line in comments * line wrap * Update keyboards/kc60se/config.h Co-Authored-By: James Young <[email protected]> * Update keyboards/kc60se/keymaps/default/keymap.c Co-Authored-By: James Young <[email protected]> * Update keyboards/kc60se/readme.md Co-Authored-By: James Young <[email protected]> * Update keyboards/kc60se/readme.md Co-Authored-By: James Young <[email protected]> * Update keyboards/kc60se/readme.md Co-Authored-By: James Young <[email protected]> * Update keyboards/kc60se/kc60se.h Co-Authored-By: James Young <[email protected]> * Update keyboards/kc60se/rules.mk Co-Authored-By: James Young <[email protected]> * Update keyboards/kc60se/info.json Co-Authored-By: James Young <[email protected]> * Update keyboards/kc60se/readme.md Co-Authored-By: James Young <[email protected]> * Update keyboards/kc60se/readme.md Co-Authored-By: James Young <[email protected]> * Update keyboards/kc60se/readme.md Co-Authored-By: James Young <[email protected]> * comment back in rules.mk * add 2 iso layouts and keymaps, 1 ansi kemap, compiled and tested * keymaps and info * Delete keymap.c not ready, I need to get a few iso characters corrected * Delete keymap.c not ready, need to get a few iso character define correctly * Update info.json Bspc to Backspace * no unicode * gui_on and gui_off in readme * Update keyboards/kc60se/rules.mk Co-Authored-By: fauxpark <[email protected]> * remove is_command * Update keyboards/kc60se/config.h remove comment Co-Authored-By: fauxpark <[email protected]> * Update keyboards/kc60se/config.h Co-Authored-By: fauxpark <[email protected]> * Update keyboards/kc60se/readme.md Co-Authored-By: fauxpark <[email protected]> * remove \\ in keymaps * Update keyboards/kc60se/info.json Co-Authored-By: James Young <[email protected]> * Update keyboards/kc60se/info.json Co-Authored-By: James Young <[email protected]> * Update keyboards/kc60se/info.json Co-Authored-By: James Young <[email protected]> * Update keyboards/kc60se/info.json Co-Authored-By: James Young <[email protected]> * Update keyboards/kc60se/kc60se.h Co-Authored-By: James Young <[email protected]> * Update keyboards/kc60se/kc60se.h Co-Authored-By: James Young <[email protected]> * Update keyboards/kc60se/kc60se.h Co-Authored-By: James Young <[email protected]> * Update keyboards/kc60se/kc60se.h Co-Authored-By: James Young <[email protected]> * Update keyboards/kc60se/info.json Co-Authored-By: James Young <[email protected]> * set led pin b2 to output mode in matrix_init_kb(), toggle it in led_update_kb() * Update config.h I had commented FORCE_NKRO out.. WHy did it com back? Co-authored-by: Check your git settings! <chris@chris-laptop> Co-authored-by: James Young <[email protected]> Co-authored-by: Ryan <[email protected]>
Description
I wrote this stuff a few years ago and mechmerlin found it, made some changes and did a pull request.
This board was not in QMK. I reverse out the board and configured QMK.
I have a set of keymaps for iso, ansi, colemak, dvorak, workman I would like to add after this pull.
No push button reset. It has a reset pad on the 6 pin ISP header.
-- Changes --
style on all files to conform to guidelines
rules.mk:
BOOTMAGIC_ENABLE = lite # esc
NKRO_ENABLE = yes # NKRO works
BACKLIGHT_ENABLE = yes # backlights not on a hw pwm pin,
# backlight works, but compile throws warning
# changing to 'software' does on/off, no levels
MOUSEKEY_ENABLE = no # none of the current keymaps have mouse map, disable
CONSOLE_ENABLE = no # docs suggest that these be off,
COMMAND_ENABLE = no # IS_COMMAND() was not defined, so it did not work
config.h:
#define FORCE_NKRO # make NKRO default
#define IS_COMMAND() # enable user to enable
#define MANUFACTURER # remove NPKC as manufacturer
# NPKC was a guess
kc60se.h:
remove caps_led inline functions
kc60se.c:
remove extern inline caps_led declarations and function
add cap_led on/off function (all in one stanza, instead of 2 files and 5 stanza)
info.json:
all, 60_ansi and 60_ansi_split_bs_rshift have layouts, created using KLE and QMK converter
I have keymaps for all and 60_ansi to add
kemaps/default/:
config.h # removed, empty file
keymap.c # T as KC_TOGG, on function layer, style and formating
Issues:
When 6KRO, can enter console/command using IS_COMMAND(c),
IS_COMMAND(n) switches to NKRO;
in NKRO mode, IS_COMMAND() will not work, can't get back to 6KRO
Solution:
BOOTMAGIC_ENABLE = lite # to enter bootloader and reduce user exposure to possible bootmagic issues
#define FORCE_NKRO # default to NKRO
NK_TOGGLE in keymap # toggles NKRO <=> 6KRO, enabling 6KRO when needed;
bootmagic lite and nk_toggle allows disabling of COMMAND/CONSOLE, which does not work when in NKRO mode
Types of Changes
Issues Fixed or Closed by This PR
none reported that I could find
Checklist