Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Illustrate the emoji layer #6555

Merged
merged 1 commit into from
Aug 17, 2019
Merged

Illustrate the emoji layer #6555

merged 1 commit into from
Aug 17, 2019

Conversation

markstos
Copy link
Contributor

Now the Emoji layer is easier to visualize.

Types of Changes

  • Enhancement/optimization
  • Documentation

Now the Emoji layer is easier to visualize.
Copy link
Contributor

@mechmerlin mechmerlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@mechmerlin mechmerlin merged commit c178bbf into qmk:master Aug 17, 2019
@zvecr
Copy link
Member

zvecr commented Aug 17, 2019

Sorry this was not caught sooner but the current QMK stance is to not change user keymaps without prior knowledge. When core functionality changes it can unfortunately propagate to keymaps, with we either ask for the users approval, or it goes through the breaking change process. Outside that we would like to minimise changes to user keymaps, and would prefer changes and improvements are driven by the keymap owner.

Again, sorry this slipped through @priyadi, if you are not happy with the outcome, we can revert the change.

Shinichi-Ohki added a commit to Shinichi-Ohki/qmk_firmware that referenced this pull request Aug 18, 2019
* 'master' of https://github.com/qmk/qmk_firmware: (53 commits)
  Add ATmega32U2 to mcu_selection.mk (qmk#6561)
  Reword a note about the MANUFACTURER and PRODUCT defines in hardware_avr.md (qmk#6558)
  Userspace kuchosauronad0 (qmk#6541)
  Illustrate the emoji layer (qmk#6555)
  Remove backslashes from template keymap (qmk#6548)
  [Keymap] add niu_mini custom keymaps (qmk#6552)
  [Keymap] add "ridingqwerty" user and keymap for atreus keyboard (qmk#6533)
  Add support for different encoder pinout for right half of split keyboard (qmk#6521)
  Fix Clueboard hotswap gen1 not compiling when LED Matrix is disabled (qmk#6427)
  Add an alternative method for keyboard discovery to speed up build (qmk#6073)
  Refactor of lets_split_eh to enable RGB split animations (qmk#6411)
  Remove duplicate test keyboards (qmk#6539)
  [Keymap] Fix include following Wilba refactor (qmk#6538)
  [Keymap] Cosmetic fix for default Wasdat keymaps (qmk#6531)
  [Keymap] Xd75 bulbizarre keymap (qmk#6525)
  [Keymap] Update gherkin to use gpio (qmk#6520)
  [Keyboard] Align xd84 and xd96 with moon (qmk#6465)
  Enable PWM Support for Planck EZ Indicator Lights  (qmk#6473)
  [Keyboard] Add: Initial steamvan firmware code (qmk#6501)
  [Keymap] Adding my userspace and keymaps (qmk#6496)
  ...
@markstos markstos deleted the patch-2 branch August 19, 2019 14:46
doughsay pushed a commit to doughsay/qmk_firmware that referenced this pull request Aug 31, 2019
Now the Emoji layer is easier to visualize.
swanmatch pushed a commit to swanmatch/qmk_firmware that referenced this pull request Sep 3, 2019
Now the Emoji layer is easier to visualize.
ripxorip pushed a commit to ripxorip/qmk_firmware that referenced this pull request Dec 3, 2019
Now the Emoji layer is easier to visualize.
ridingqwerty pushed a commit to ridingqwerty/qmk_firmware that referenced this pull request Jan 10, 2020
Now the Emoji layer is easier to visualize.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants