Add an alternative method for keyboard discovery to speed up build #6073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drashna
requested review from
jackhumbert,
drashna,
algernon,
fredizzimo,
mechmerlin,
noroadsleft,
skullydazed and
yanfali
10 tasks
zvecr
force-pushed
the
feature/get_keyboard_speed
branch
from
f7dbb33 to
fd8280a
Compare
skullydazed
approved these changes
Jul 16, 2019
zvecr
force-pushed
the
feature/get_keyboard_speed
branch
from
fd8280a to
a1793c7
Compare
drashna
approved these changes
Jul 30, 2019
yanfali
approved these changes
Jul 31, 2019
|
I figured it would help get the PR in sooner, as I would have to test it on the platforms for portability. Would people agree to a 2nd pass for updating the default behaviour, and then much testing? |
|
Was this okay, as is? |
|
@drashna Should be fine as is. We can get some confidence with the alt method, and maybe open up another PR to change the default at a later date. |
|
Well, unless there is an objection, I think i"m going to merge this, then. |
Shinichi-Ohki
added a commit
to Shinichi-Ohki/qmk_firmware
that referenced
this pull request
Aug 18, 2019
* 'master' of https://github.com/qmk/qmk_firmware: (53 commits) Add ATmega32U2 to mcu_selection.mk (qmk#6561) Reword a note about the MANUFACTURER and PRODUCT defines in hardware_avr.md (qmk#6558) Userspace kuchosauronad0 (qmk#6541) Illustrate the emoji layer (qmk#6555) Remove backslashes from template keymap (qmk#6548) [Keymap] add niu_mini custom keymaps (qmk#6552) [Keymap] add "ridingqwerty" user and keymap for atreus keyboard (qmk#6533) Add support for different encoder pinout for right half of split keyboard (qmk#6521) Fix Clueboard hotswap gen1 not compiling when LED Matrix is disabled (qmk#6427) Add an alternative method for keyboard discovery to speed up build (qmk#6073) Refactor of lets_split_eh to enable RGB split animations (qmk#6411) Remove duplicate test keyboards (qmk#6539) [Keymap] Fix include following Wilba refactor (qmk#6538) [Keymap] Cosmetic fix for default Wasdat keymaps (qmk#6531) [Keymap] Xd75 bulbizarre keymap (qmk#6525) [Keymap] Update gherkin to use gpio (qmk#6520) [Keyboard] Align xd84 and xd96 with moon (qmk#6465) Enable PWM Support for Planck EZ Indicator Lights (qmk#6473) [Keyboard] Add: Initial steamvan firmware code (qmk#6501) [Keymap] Adding my userspace and keymaps (qmk#6496) ...
drashna
pushed a commit
to zsa/qmk_firmware
that referenced
this pull request
Aug 27, 2019
…mk#6073) * Add an alternative method for keyboard discovery to speed up build * Chain MAKEFLAGS for docker_build.sh * Slight improvement to number of items sent to sort * Remove debug line * Fix line escape
fdidron
pushed a commit
to zsa/qmk_firmware
that referenced
this pull request
Aug 28, 2019
…mk#6073) * Add an alternative method for keyboard discovery to speed up build * Chain MAKEFLAGS for docker_build.sh * Slight improvement to number of items sent to sort * Remove debug line * Fix line escape
doughsay
pushed a commit
to doughsay/qmk_firmware
that referenced
this pull request
Aug 31, 2019
…mk#6073) * Add an alternative method for keyboard discovery to speed up build * Chain MAKEFLAGS for docker_build.sh * Slight improvement to number of items sent to sort * Remove debug line * Fix line escape
swanmatch
pushed a commit
to swanmatch/qmk_firmware
that referenced
this pull request
Sep 3, 2019
…mk#6073) * Add an alternative method for keyboard discovery to speed up build * Chain MAKEFLAGS for docker_build.sh * Slight improvement to number of items sent to sort * Remove debug line * Fix line escape
fdidron
pushed a commit
to zsa/qmk_firmware
that referenced
this pull request
Sep 5, 2019
…mk#6073) * Add an alternative method for keyboard discovery to speed up build * Chain MAKEFLAGS for docker_build.sh * Slight improvement to number of items sent to sort * Remove debug line * Fix line escape
ripxorip
pushed a commit
to ripxorip/qmk_firmware
that referenced
this pull request
Dec 3, 2019
…mk#6073) * Add an alternative method for keyboard discovery to speed up build * Chain MAKEFLAGS for docker_build.sh * Slight improvement to number of items sent to sort * Remove debug line * Fix line escape
ridingqwerty
pushed a commit
to ridingqwerty/qmk_firmware
that referenced
this pull request
Jan 10, 2020
…mk#6073) * Add an alternative method for keyboard discovery to speed up build * Chain MAKEFLAGS for docker_build.sh * Slight improvement to number of items sent to sort * Remove debug line * Fix line escape
BorisTestov
pushed a commit
to BorisTestov/qmk_firmware
that referenced
this pull request
May 23, 2024
…mk#6073) * Add an alternative method for keyboard discovery to speed up build * Chain MAKEFLAGS for docker_build.sh * Slight improvement to number of items sent to sort * Remove debug line * Fix line escape
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Discussed within #6065.
The main take-away is that windows vagrant and macos docker can have poor filesystem performance. This PR attempts to work around that issue by providing a method of keyboard discovery that seems to be faster, up to a factor of 3x.
Types of Changes
Checklist