Add support for different encoder pinout for right half of split keyboard #6521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zvecr
approved these changes
Aug 12, 2019
drashna
approved these changes
Aug 13, 2019
|
Just wondering, how this interacts with: #6382 |
|
@drashna Dunno, haven't really checked into it. |
|
Okay. Well, I think this should be merged first, since it's a more important change (on account of what it does). |
13 tasks
Shinichi-Ohki
added a commit
to Shinichi-Ohki/qmk_firmware
that referenced
this pull request
Aug 18, 2019
* 'master' of https://github.com/qmk/qmk_firmware: (53 commits) Add ATmega32U2 to mcu_selection.mk (qmk#6561) Reword a note about the MANUFACTURER and PRODUCT defines in hardware_avr.md (qmk#6558) Userspace kuchosauronad0 (qmk#6541) Illustrate the emoji layer (qmk#6555) Remove backslashes from template keymap (qmk#6548) [Keymap] add niu_mini custom keymaps (qmk#6552) [Keymap] add "ridingqwerty" user and keymap for atreus keyboard (qmk#6533) Add support for different encoder pinout for right half of split keyboard (qmk#6521) Fix Clueboard hotswap gen1 not compiling when LED Matrix is disabled (qmk#6427) Add an alternative method for keyboard discovery to speed up build (qmk#6073) Refactor of lets_split_eh to enable RGB split animations (qmk#6411) Remove duplicate test keyboards (qmk#6539) [Keymap] Fix include following Wilba refactor (qmk#6538) [Keymap] Cosmetic fix for default Wasdat keymaps (qmk#6531) [Keymap] Xd75 bulbizarre keymap (qmk#6525) [Keymap] Update gherkin to use gpio (qmk#6520) [Keyboard] Align xd84 and xd96 with moon (qmk#6465) Enable PWM Support for Planck EZ Indicator Lights (qmk#6473) [Keyboard] Add: Initial steamvan firmware code (qmk#6501) [Keymap] Adding my userspace and keymaps (qmk#6496) ...
drashna
pushed a commit
to zsa/qmk_firmware
that referenced
this pull request
Aug 27, 2019
…oard (qmk#6521) * Add support for different encoder pinouts for split keyboard * Update documentation for new encoder pinout feature
fdidron
pushed a commit
to zsa/qmk_firmware
that referenced
this pull request
Aug 28, 2019
…oard (qmk#6521) * Add support for different encoder pinouts for split keyboard * Update documentation for new encoder pinout feature
doughsay
pushed a commit
to doughsay/qmk_firmware
that referenced
this pull request
Aug 31, 2019
…oard (qmk#6521) * Add support for different encoder pinouts for split keyboard * Update documentation for new encoder pinout feature
swanmatch
pushed a commit
to swanmatch/qmk_firmware
that referenced
this pull request
Sep 3, 2019
…oard (qmk#6521) * Add support for different encoder pinouts for split keyboard * Update documentation for new encoder pinout feature
fdidron
pushed a commit
to zsa/qmk_firmware
that referenced
this pull request
Sep 5, 2019
…oard (qmk#6521) * Add support for different encoder pinouts for split keyboard * Update documentation for new encoder pinout feature
ripxorip
pushed a commit
to ripxorip/qmk_firmware
that referenced
this pull request
Dec 3, 2019
…oard (qmk#6521) * Add support for different encoder pinouts for split keyboard * Update documentation for new encoder pinout feature
ridingqwerty
pushed a commit
to ridingqwerty/qmk_firmware
that referenced
this pull request
Jan 10, 2020
…oard (qmk#6521) * Add support for different encoder pinouts for split keyboard * Update documentation for new encoder pinout feature
BorisTestov
pushed a commit
to BorisTestov/qmk_firmware
that referenced
this pull request
May 23, 2024
…oard (qmk#6521) * Add support for different encoder pinouts for split keyboard * Update documentation for new encoder pinout feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds option to define
ENCODERS_PAD_A_RIGHTandENCODERS_PAD_B_RIGHTto allow right half of split keyboard to have a different encoder pinout than the left half. Needed for upcoming Iris Rev. 4.Types of Changes
Issues Fixed or Closed by This PR
Checklist