Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Satisfaction75 i2c fix and VIA layout #5726

Merged
merged 1 commit into from
Apr 28, 2019

Conversation

awkannan
Copy link
Contributor

@awkannan awkannan commented Apr 27, 2019

Description

Fix i2c_master.c in Satisfaction75 firmware, and update the VIA keymap for the rev1 PCB

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • Read title :P

Checklist

  • [X ] My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • [X ] I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • [ X] I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@mechmerlin
Copy link
Contributor

I'm guessing no chibios support for QMK's i2cmaster yet?

Copy link
Contributor

@yanfali yanfali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@awkannan
Copy link
Contributor Author

@mechmerlin there is some support for QMK i2c_master but its for a single chip. Since I'm using not f303, my config has to be different and that's not baked in yet.

@drashna drashna merged commit b23c3b0 into qmk:master Apr 28, 2019
@noroadsleft
Copy link
Member

@awkannan You should check out #5669.

akrob pushed a commit to akrob/qmk_firmware that referenced this pull request Apr 30, 2019
* upstream/master: (779 commits)
  [Keyboard] Signum3.0 remove sortedcontainers (qmk#5679)
  Simple extended space cadet (qmk#5277)
  Removed forced in lining for lib8tion functions (qmk#5670)
  Change lib8tion library to be usable in user keymaps (qmk#5598)
  [Keyboard] Fixing drag-and-drop (qmk#5728)
  [Keyboard] Adding ortho_4x12 & planck_mit layouts for KBD4X (qmk#5729)
  [Keyboard] Minor fixes for Baguette (qmk#5737)
  Updated rgb_led struct field modifier to flags (qmk#5619)
  RGB Matrix: Custom effects on a kb/user level (qmk#5338)
  Fix Planck and Preonic builds (qmk#5658)
  [Keymap] dz60 keymap w/ hhkb-esque default layer (qmk#5708)
  [Keymap] Added compatibility for Planck rev6 (qmk#5706)
  [Keyboard] Satisfaction75 i2c fix and VIA layout (qmk#5726)
  A better new_project.sh (qmk#5191)
  Fix sendstring "#" producing "£" instead (qmk#5724)
  [Keyboard] Added WT69-A PCB (qmk#5721)
  [Keymap] Fix typo and function layer image for Quefrency (qmk#5719)
  [Keymap] Initial keyboard layout for KBD67 (qmk#5720)
  [Keymap] New keymap for Quefrency 65% with split backspace, RGB, media keys, mouse keys (qmk#5717)
  [Keyboard] Update Gergo to use newer Ergodox Matrix code (qmk#5703)
  ...
foosinn pushed a commit to foosinn/qmk_firmware that referenced this pull request May 6, 2019
Timbus pushed a commit to Timbus/qmk_firmware that referenced this pull request Jun 23, 2019
ridingqwerty pushed a commit to ridingqwerty/qmk_firmware that referenced this pull request Jan 10, 2020
JeffreyPalmer pushed a commit to JeffreyPalmer/qmk_firmware that referenced this pull request Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants