Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dz60 keymap w/ hhkb-esque default layer #5708

Merged
merged 2 commits into from
Apr 29, 2019
Merged

dz60 keymap w/ hhkb-esque default layer #5708

merged 2 commits into from
Apr 29, 2019

Conversation

loChris
Copy link
Contributor

@loChris loChris commented Apr 26, 2019

-Changed caps for control
-Changed leftctrl to capslock
-navigation to fn layer

@loChris loChris changed the title My keymap for dz60 with some hhkb keys My keymap for dz60 with similar hhkb keys Apr 26, 2019
KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS),

LAYOUT(
KC_TRNS, M(1), M(2), M(3), M(4), M(5), M(6), M(7), M(8), M(9), M(10), M(11), M(12), KC_TRNS, KC_TRNS,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You only have 3 layers defined here but yet your Fn keys here go all the way until Layer 12. Is this intentional?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mechmerlin M(#) are for the old TMK-style macro keys. This keymap doesn't use them (no action_get_macro block), so there's no function here.

@loChris, all these M(#) keys should probably be swapped out for KC_TRNS. That change would make this layer empty, so realistically you could delete the layer.

Also, depending on whether your DZ60 has a hardware reset switch, you may want to include a RESET keycode here, which would be a good use of this layer.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mechmerlin @noroadsleft Hey guys! I apologize for the lack of organization with my commit.

My first board got here yesterday and I just learned how to use qmk.

In VSCode I can only see the 3 layers that were initially there and which I started personalizing. I'm going to try to get rid of layer 4-12, if I can access them, because I won't really be using those.

@noroadsleft To be clear: You're suggesting I turn layer 3 into a dedicated RESET layer?

Other than the awkwardness of the layers (and title/message), is there anything else I should change?

Thanks!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@loChris

@noroadsleft To be clear: You're suggesting I turn layer 3 into a dedicated RESET layer?

Pretty much. I personally like to keep keycodes that handle the hardware separate from keycodes that are for typing and software. I have a dedicated layer for changing my base layer, adjusting backlighting, resetting to bootloader, and the like. I used to have my RESET key on a normal function layer, but I'd hit it accidentally all the time and have to replug the board to continue typing.


Also, you've filed this pull request from your fork's master branch. While this isn't a major issue now, later changes may result in merge conflicts if you try to file another PR because the commit history will have diverged between your master and QMK's. It is highly recommended for QMK development - regardless of what is being done or where - to keep your master updated, but NEVER commit to it. Instead, do all your changes in a branch (branches are basically free in Git) and issue PRs from your branches when you're developing.

There are instructions on how to keep your master updated here:

Best Practices: Your fork's master: Update Often, Commit Never

If you need any help with this just ask.

@loChris loChris changed the title My keymap for dz60 with similar hhkb keys dz60 keymap w/ hhkb-esque default layer Apr 26, 2019
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@drashna drashna merged commit 6806398 into qmk:master Apr 29, 2019
akrob pushed a commit to akrob/qmk_firmware that referenced this pull request Apr 30, 2019
* upstream/master: (779 commits)
  [Keyboard] Signum3.0 remove sortedcontainers (qmk#5679)
  Simple extended space cadet (qmk#5277)
  Removed forced in lining for lib8tion functions (qmk#5670)
  Change lib8tion library to be usable in user keymaps (qmk#5598)
  [Keyboard] Fixing drag-and-drop (qmk#5728)
  [Keyboard] Adding ortho_4x12 & planck_mit layouts for KBD4X (qmk#5729)
  [Keyboard] Minor fixes for Baguette (qmk#5737)
  Updated rgb_led struct field modifier to flags (qmk#5619)
  RGB Matrix: Custom effects on a kb/user level (qmk#5338)
  Fix Planck and Preonic builds (qmk#5658)
  [Keymap] dz60 keymap w/ hhkb-esque default layer (qmk#5708)
  [Keymap] Added compatibility for Planck rev6 (qmk#5706)
  [Keyboard] Satisfaction75 i2c fix and VIA layout (qmk#5726)
  A better new_project.sh (qmk#5191)
  Fix sendstring "#" producing "£" instead (qmk#5724)
  [Keyboard] Added WT69-A PCB (qmk#5721)
  [Keymap] Fix typo and function layer image for Quefrency (qmk#5719)
  [Keymap] Initial keyboard layout for KBD67 (qmk#5720)
  [Keymap] New keymap for Quefrency 65% with split backspace, RGB, media keys, mouse keys (qmk#5717)
  [Keyboard] Update Gergo to use newer Ergodox Matrix code (qmk#5703)
  ...
foosinn pushed a commit to foosinn/qmk_firmware that referenced this pull request May 6, 2019
* hello world

* Update keyboards/dz60/keymaps/zepol_layout/keymap.c

Co-Authored-By: loChris <[email protected]>
Timbus pushed a commit to Timbus/qmk_firmware that referenced this pull request Jun 23, 2019
* hello world

* Update keyboards/dz60/keymaps/zepol_layout/keymap.c

Co-Authored-By: loChris <[email protected]>
@markstos
Copy link
Contributor

A Readme for this keymap would be helpful to note what's special about it. Some visuals of the layout layout would be helpful as well.

ridingqwerty pushed a commit to ridingqwerty/qmk_firmware that referenced this pull request Jan 10, 2020
* hello world

* Update keyboards/dz60/keymaps/zepol_layout/keymap.c

Co-Authored-By: loChris <[email protected]>
JeffreyPalmer pushed a commit to JeffreyPalmer/qmk_firmware that referenced this pull request Feb 27, 2020
* hello world

* Update keyboards/dz60/keymaps/zepol_layout/keymap.c

Co-Authored-By: loChris <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants