Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keyboard: add treeadstone48 #5405

Merged
merged 9 commits into from
Apr 4, 2019
Merged

Keyboard: add treeadstone48 #5405

merged 9 commits into from
Apr 4, 2019

Conversation

marksard
Copy link
Contributor

Description

Add treadstone48 keyboard

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

mechmerlin
mechmerlin requested changes Mar 15, 2019
View reviewed changes
Copy link
Contributor

@mechmerlin mechmerlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These requested changes are primarily QMK stye convention changes such as using all lower case description for layouts such as LAYOUT_lower_case_desc and the usage of #pragma once over the usual ifndef def include guards

keyboards/treadstone48/rev1/rev1.h Outdated Show resolved Hide resolved
keyboards/treadstone48/rev1/rev1.h Outdated Show resolved Hide resolved
keyboards/treadstone48/rev1/rev1.h Outdated Show resolved Hide resolved
keyboards/treadstone48/rev1/rev1.h Outdated Show resolved Hide resolved
keyboards/treadstone48/rev1/rev1.h Outdated Show resolved Hide resolved
keyboards/treadstone48/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/treadstone48/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/treadstone48/keymaps/default/readme_jp.md Outdated Show resolved Hide resolved
keyboards/treadstone48/keymaps/default/readme_jp.md Outdated Show resolved Hide resolved
keyboards/treadstone48/keymaps/default/readme_jp.md Outdated Show resolved Hide resolved
@marksard
Copy link
Contributor Author

@mechmerlin thanks,
I was rename LAYOUT_****
regards,

@drashna
Copy link
Member

drashna commented Mar 30, 2019

Just a heads up, there are 2 OLED PRs in the queue that may improve the usability/functionality of the screens. It won't replace the implementation here, but it may be better to run once one of them is merged in.

Additionally, we hope to merge the split keyboard code into one, unified framework in the near future, and we'd like to convert all the boards like this to use that framework, at some point. (that way, when somebody like @mtei updates the code for the helix, every board benefits, and we don't have fragmented boards)

noroadsleft
noroadsleft requested changes Mar 30, 2019
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to the specific issues below, as all your keymaps in this pull request are reference keymaps instead of user keymaps, they should all be refactored to not use layout macro that will automatically prepend KC_ to all keycodes, as QMK has found that this confuses new users.

Here's an updated default keymap.

https://github.com/noroadsleft/qmk_firmware/blob/9ec608626156f362723064be990014be6bf65bbf/keyboards/treadstone48/keymaps/default/keymap.c

The like_jis and like_jis_rs keymaps should both be similarly updated as well.

keyboards/treadstone48/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/treadstone48/keymaps/like_jis/keymap.c Outdated Show resolved Hide resolved
keyboards/treadstone48/keymaps/like_jis_rs/keymap.c Outdated Show resolved Hide resolved
keyboards/treadstone48/info.json Outdated Show resolved Hide resolved
keyboards/treadstone48/rev1/info.json Outdated Show resolved Hide resolved
noroadsleft
noroadsleft requested changes Mar 31, 2019
View reviewed changes
keyboards/treadstone48/rev1/info.json Outdated Show resolved Hide resolved
keyboards/treadstone48/rev1/info.json Show resolved Hide resolved
drashna
drashna requested changes Apr 3, 2019
View reviewed changes
keyboards/treadstone48/config.h Outdated Show resolved Hide resolved
keyboards/treadstone48/config.h Outdated Show resolved Hide resolved
keyboards/treadstone48/config.h Outdated Show resolved Hide resolved
@drashna
Copy link
Member

drashna commented Apr 4, 2019

Thanks!

@drashna drashna merged commit debd902 into qmk:master Apr 4, 2019
legooolas added a commit to legooolas/qmk_firmware that referenced this pull request Apr 5, 2019
@legooolas
Merge remote-tracking branch 'upstream/master'
22dad46 
* upstream/master: (445 commits)
  Update ps2avrgb template to use standard matrix/i2c code (qmk#4957)
  [Keyboard] Simplified handwired/xealous since most of the features are in core now. (qmk#5556)
  [Keyboard] Move scrabblepad into donutcables directory (qmk#5553)
  [Keymap] Additional RGB options set (qmk#5551)
  [Keyboard] Add Budget96 by Donut Cables (qmk#5550)
  [Keyboard] Added configurable defaults for RGB backlight parameters. (qmk#5549)
  Added Hacked Motospeed keyboard (qmk#5534)
  [Keymap] New HS60/v2 HHKB keymap for goatmaster (qmk#5545)
  [Keyboard] add treeadstone48 (qmk#5405)
  [Keyboard] Doro67 Multi PCB port (qmk#5539)
  [Keyboard] V60 Type R - Turn on leds for Configurator + Refactor (qmk#5546)
  RGB Matrix support for Massdrop CTRL/ALT (qmk#5328)
  Added encoder support to split common code (qmk#5477)
  Eager Per Row Debouncing added (added to Ergodox) (qmk#5498)
  Added configurable defaults for RGB backlight indicators.
  [Keyboard] Small Refactor of Duck boards (qmk#5521)
  [Keyboard] Quantrik Kyuu 65% Board (qmk#5541)
  Call default zeal60 rgb file
  remove call to custom rgb file
  Removed duplicated zeal60 files
  ...
danielo515 pushed a commit to danielo515/qmk_firmware that referenced this pull request May 15, 2019
@marksard @danielo515
[Keyboard] add treeadstone48 (qmk#5405)
6c0fbcc 
* Keyboard: add treeadstone48

* rename layout defines

* Use of pragma once

* move common include code

* fixed info.json

* change keymap layout from kc to normal

* fix alpha revision keymap

* fixed info.json

* remove USE_Link_Time_Optimization
shimesaba-type0 pushed a commit to shimesaba-type0/qmk_firmware that referenced this pull request Jun 22, 2019
@marksard @shimesaba-type0
[Keyboard] add treeadstone48 (qmk#5405)
199ffe0 
* Keyboard: add treeadstone48

* rename layout defines

* Use of pragma once

* move common include code

* fixed info.json

* change keymap layout from kc to normal

* fix alpha revision keymap

* fixed info.json

* remove USE_Link_Time_Optimization
Timbus pushed a commit to Timbus/qmk_firmware that referenced this pull request Jun 23, 2019
@marksard @Timbus
[Keyboard] add treeadstone48 (qmk#5405)
5db424c 
* Keyboard: add treeadstone48

* rename layout defines

* Use of pragma once

* move common include code

* fixed info.json

* change keymap layout from kc to normal

* fix alpha revision keymap

* fixed info.json

* remove USE_Link_Time_Optimization
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mechmerlin mechmerlin mechmerlin requested changes

@noroadsleft noroadsleft noroadsleft requested changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marksard @drashna @noroadsleft @mechmerlin