Adds Gray Studio HB85 Initial Support #5311

fcoury · 2019-03-05T01:50:07Z

HB85 uses ps2avrGB firmware, so used the same matrix used by the TGR Alice but added additional rows.

Description

Types of Changes

Checklist

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
I have tested the changes and verified that they work and don't break anything (as well as I can manage).

fcoury · 2019-03-05T01:55:26Z

Here's how the matrix looks on Bootmapper Client:

I also checked the pins manually with a multimeter and they are all apparently correct.

mechmerlin · 2019-03-05T20:29:14Z

Can you put this in the gray_studio directory.

fcoury · 2019-03-05T20:29:54Z

Can you put this in the gray_studio directory.

Of course! Making the change right now.

fcoury · 2019-03-05T22:14:54Z

@mechmerlin this is feature complete, ready for review.

drashna

Additionally, could you remove the i2c files, and instead, use the correct functions as found in /drivers/avr/i2c_master.c?

drashna · 2019-03-05T23:37:13Z

keyboards/gray_studio/hb85/hb85.c

+}
+
+void backlight_init_ports(void) {
+	DDRD |= (1<<0 | 1<<1 | 1<<4 | 1<<6);


Could you update these to use the GPIO Control functions, instead?

https://docs.qmk.fm/#/internals_gpio_control

@drashna can you point me in the right direction of how the GPIO functions would translate here? I will implement it on the other part myself, just need some guidance.

Well, the actual code to handle this is here:
https://github.com/qmk/qmk_firmware/blob/master/quantum/quantum.h#L147-L169

That would be the best reference, but not the most intuitive.

A good example is one of my commits, converting everything to these:
4038308?w=1

Though, this may take a bit of testing to make sure that it's using the correct commands.

drashna · 2019-03-05T23:37:23Z

keyboards/gray_studio/hb85/hb85.c

+void backlight_set(uint8_t level) {
+	if (level == 0) {
+		// Turn out the lights
+		PORTD &= ~(1<<0 | 1<<1 | 1<<4 | 1<<6);


Could you update these to use the GPIO Control functions, instead?

https://docs.qmk.fm/#/internals_gpio_control

drashna · 2019-03-05T23:38:09Z

keyboards/gray_studio/hb85/i2c.c

@@ -0,0 +1,106 @@
+/*


Cries in i2c

drashna · 2019-03-05T23:38:56Z

keyboards/gray_studio/hb85/rules.mk

+
+OPT_DEFS = -DDEBUG_LEVEL=0
+
+SRC += i2c.c


Suggested change

SRC += i2c.c

SRC += i2c_master.c

fcoury · 2019-03-05T23:42:12Z

Additionally, could you remove the i2c files, and instead, use the correct functions as found in /drivers/avr/i2c_master.c?

@drashna thanks so much for the review! I reported here on this thread, but sorry for not making it more clear. If I use ic2_master it crashes on the first i2c_transmit call. Getting i2c.c back into the folder was the only way I could make this particular board work.

I am open to ideas on how to move forward.

drashna · 2019-03-06T06:00:04Z

Well, it seems that things are handled very different, But I'm guessing that you tried the method that the Alice used, but without success?

I suspect you have already. But I'm not sure.

fcoury · 2019-03-06T13:49:38Z

@drashna yes, that was my original attempt. If you look at the commit history I started with i2c_master but it never worked.

pelrun · 2019-03-06T15:06:54Z

~~You should have been using address 0x58 in i2c_transmit instead of 0xb0.~~

Edit: not actually true. Documentation needs fixing.

fcoury · 2019-03-06T15:17:05Z

@pelrun whoa, seriously!? Thanks!

How did you find that? I even analyzed ps2avrGB source code and the underglow pin is 0xb0.

I will give it a shot when I get back home, but would you mind explaining why 0x58?

pelrun · 2019-03-06T15:33:58Z

I2C slave addresses are only 7 bit. On the wire they're sent MSB first, and then followed by the read/write bit. Manually doing the transaction means passing (slave_addr << 1 | rw_flag) as the first byte. But i2c_transmit should take slave_addr directly.

pelrun · 2019-03-06T15:36:35Z

...and crap, it looks like the avr version of i2c_transmit isn't doing that properly anyway. At the very least, the documentation, and the avr and arm drivers are inconsistent.

pelrun · 2019-03-06T15:41:30Z

In any case, I'm waiting on #4974 to land, which fixes some issues with i2c_master on avr, so you could have been affected by that.

fcoury · 2019-03-06T15:43:41Z

Ok that is very interesting @pelrun, thank you very much.

@drashna since this is working as is would you consider approving it and I will refactor it to use i2c_master once those fixes are in?

Let me know what you think is best.

keyboards/gray_studio/hb85/program

keyboards/gray_studio/hb85/rules.mk

As per zvecr feedback

fcoury · 2019-03-06T19:21:38Z

@zvecr all your feedback has been addressed. I think the only thing left is using the GPIO pins functions on the two spots @drashna pointed out. I am not sure how to use them, so if you can point me in the right direction that would be appreciated as well.

Once again thank you for your review!

drashna · 2019-03-06T19:50:50Z

@drashna since this is working as is would you consider approving it and I will refactor it to use i2c_master once those fixes are in?

Yeah, that sounds good to me.

I think the only thing left is using the GPIO pins functions on the two spots @drashna pointed out. I am not sure how to use them, so if you can point me in the right direction that would be appreciated as well.

Posted above, but again, here is an example from when I did this:
4038308?w=1

The only missing command is:
writePinLow.

fcoury · 2019-03-06T20:38:23Z

@drashna converted and tested:

drashna · 2019-03-06T20:49:07Z

Awesome, thanks!

* 'master' of https://github.com/qmk/qmk_firmware: (76 commits) [Keyboard] Adds Gray Studio HB85 Initial Support (qmk#5311) [Keymap] Add KC_MAKE keycode to my userspace and keymaps (qmk#5324) [Keyboard] handwired/trackpoint: refactor and readme cleanup (qmk#5325) [Keyboard] re-arrange the pinout for backlight support (qmk#5321) [Keymap] update: simplify tapdance code for Minidox/keymaps/dustypomerleau (qmk#5315) [Keymap] Add vxid planck layout (qmk#5271) increase size of note counter variable to avoid overflow Adopted LAYOUT, added some keys (qmk#5320) Add more "decent" text editors (qmk#5308) Add DZ60 Tsangan Layout + Fn layer (qmk#5319) [Docs] Fix function signature (layer_state_set_*) (qmk#5313) Correct keyboard and layout dimensions for 40percent.club Foobar (qmk#5310) Dactyl Manuform 5x6, 5x7, and 6x6: QMK Configurator fixes and partial code clean-up (qmk#5307) Fixed default to dissable VIA (qmk#5309) Clean up debounce a bit (qmk#5255) Fix aanzee Configurator config file (qmk#5286) Separate keymaps to VIA enabled/dissabled. (qmk#5302) [Keymap] Add RGB config and controls to userspace (qmk#5299) Add LED Matrix to Features list for easy reference (qmk#5280) [Keymap] layout/community/ortho4x12/symbolic update (qmk#5274) ...

* Gray Studio HB85 Initial Support * Fixed README image * Updated README * Disabled Bootmagic and Console for HB85 * Fixed Numpad 4 matrix place * Fixes board crashing with RGB enabled * Moved HB85 files to gray_studio folder * Uses old i2c library since this version makes RGB underglow work * Improved default keymap with underglow control layer * Removes obsolete program and uses generic script instead As per zvecr feedback * Uses GPIO Functions to initialise and set RGB underglow PINS

Gray Studio HB85 Initial Support

60b892b

fcoury added 3 commits March 4, 2019 23:00

Fixed README image

55281b9

Updated README

dde7761

Disabled Bootmagic and Console for HB85

4fce251

fcoury marked this pull request as ready for review March 5, 2019 15:36

fcoury added 2 commits March 5, 2019 12:52

Fixed Numpad 4 matrix place

e3988bd

Fixes board crashing with RGB enabled

2f7dc00

fcoury added 2 commits March 5, 2019 17:37

Moved HB85 files to gray_studio folder

5532c6d

Uses old i2c library since this version makes RGB underglow work

1b07a98

Improved default keymap with underglow control layer

0b375f8

drashna requested changes Mar 5, 2019

View reviewed changes

drashna added the keyboard label Mar 5, 2019

zvecr requested changes Mar 6, 2019

View reviewed changes

keyboards/gray_studio/hb85/program Outdated Show resolved Hide resolved

keyboards/gray_studio/hb85/rules.mk Outdated Show resolved Hide resolved

Removes obsolete program and uses generic script instead

37f0d58

As per zvecr feedback

Uses GPIO Functions to initialise and set RGB underglow PINS

7864215

drashna approved these changes Mar 6, 2019

View reviewed changes

drashna merged commit ba11a1c into qmk:master Mar 6, 2019

fcoury deleted the hb85 branch March 6, 2019 20:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds Gray Studio HB85 Initial Support #5311

Adds Gray Studio HB85 Initial Support #5311

fcoury commented Mar 5, 2019 •

edited

Loading

fcoury commented Mar 5, 2019

mechmerlin commented Mar 5, 2019

fcoury commented Mar 5, 2019

fcoury commented Mar 5, 2019

drashna left a comment

drashna Mar 5, 2019

fcoury Mar 6, 2019

drashna Mar 6, 2019

drashna Mar 5, 2019

drashna Mar 5, 2019

drashna Mar 5, 2019

fcoury commented Mar 5, 2019

drashna commented Mar 6, 2019

fcoury commented Mar 6, 2019

pelrun commented Mar 6, 2019 •

edited

Loading

fcoury commented Mar 6, 2019

pelrun commented Mar 6, 2019

pelrun commented Mar 6, 2019

pelrun commented Mar 6, 2019

fcoury commented Mar 6, 2019

fcoury commented Mar 6, 2019

drashna commented Mar 6, 2019

fcoury commented Mar 6, 2019

drashna commented Mar 6, 2019

Adds Gray Studio HB85 Initial Support #5311

Adds Gray Studio HB85 Initial Support #5311

Conversation

fcoury commented Mar 5, 2019 • edited Loading

Description

Types of Changes

Checklist

fcoury commented Mar 5, 2019

mechmerlin commented Mar 5, 2019

fcoury commented Mar 5, 2019

fcoury commented Mar 5, 2019

drashna left a comment

Choose a reason for hiding this comment

drashna Mar 5, 2019

Choose a reason for hiding this comment

fcoury Mar 6, 2019

Choose a reason for hiding this comment

drashna Mar 6, 2019

Choose a reason for hiding this comment

drashna Mar 5, 2019

Choose a reason for hiding this comment

drashna Mar 5, 2019

Choose a reason for hiding this comment

drashna Mar 5, 2019

Choose a reason for hiding this comment

fcoury commented Mar 5, 2019

drashna commented Mar 6, 2019

fcoury commented Mar 6, 2019

pelrun commented Mar 6, 2019 • edited Loading

fcoury commented Mar 6, 2019

pelrun commented Mar 6, 2019

pelrun commented Mar 6, 2019

pelrun commented Mar 6, 2019

fcoury commented Mar 6, 2019

fcoury commented Mar 6, 2019

drashna commented Mar 6, 2019

fcoury commented Mar 6, 2019

drashna commented Mar 6, 2019

fcoury commented Mar 5, 2019 •

edited

Loading

pelrun commented Mar 6, 2019 •

edited

Loading