Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix westfoxtrot/aanzee Configurator config #5286

Merged
merged 1 commit into from
Mar 4, 2019

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Mar 1, 2019

Description

Spotted within the output of http://compile.qmk.fm/v1/keyboards/error_log.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr changed the title Fix aanzee Configurator config file Fix westfoxtrot/aanzee config file Mar 1, 2019
@zvecr zvecr changed the title Fix westfoxtrot/aanzee config file Fix westfoxtrot/aanzee Configurator config Mar 2, 2019
@mechmerlin
Copy link
Contributor

@westfoxtrot I knew you said you were gonna work on this so I thought it would be a good idea to have you on this PR too.

@westfoxtrot
Copy link
Contributor

@zvecr thanks! I am still learning all this stuff so appreciate you taking the time to fix my mistake

Copy link
Contributor

@mechmerlin mechmerlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mechmerlin mechmerlin merged commit cdfcbfc into qmk:master Mar 4, 2019
Shinichi-Ohki added a commit to Shinichi-Ohki/qmk_firmware that referenced this pull request Mar 7, 2019
* 'master' of https://github.com/qmk/qmk_firmware: (76 commits)
  [Keyboard] Adds Gray Studio HB85 Initial Support (qmk#5311)
  [Keymap] Add KC_MAKE keycode to my userspace and keymaps (qmk#5324)
  [Keyboard] handwired/trackpoint: refactor and readme cleanup (qmk#5325)
  [Keyboard] re-arrange the pinout for backlight support (qmk#5321)
  [Keymap] update: simplify tapdance code for Minidox/keymaps/dustypomerleau (qmk#5315)
  [Keymap] Add vxid planck layout (qmk#5271)
  increase size of note counter variable to avoid overflow
  Adopted LAYOUT, added some keys (qmk#5320)
  Add more "decent" text editors (qmk#5308)
  Add DZ60 Tsangan Layout + Fn layer (qmk#5319)
  [Docs] Fix function signature (layer_state_set_*) (qmk#5313)
  Correct keyboard and layout dimensions for 40percent.club Foobar (qmk#5310)
  Dactyl Manuform 5x6, 5x7, and 6x6: QMK Configurator fixes and partial code clean-up (qmk#5307)
  Fixed default to dissable VIA (qmk#5309)
  Clean up debounce a bit (qmk#5255)
  Fix aanzee Configurator config file (qmk#5286)
  Separate keymaps to VIA enabled/dissabled. (qmk#5302)
  [Keymap] Add RGB config and controls to userspace (qmk#5299)
  Add LED Matrix to Features list for easy reference (qmk#5280)
  [Keymap] layout/community/ortho4x12/symbolic update (qmk#5274)
  ...
slugger7 pushed a commit to slugger7/qmk_firmware that referenced this pull request Mar 7, 2019
@zvecr zvecr deleted the feature/aanzee_configurator branch March 15, 2019 01:21
chie4hao pushed a commit to chie4hao/qmk_firmware that referenced this pull request Mar 28, 2019
zer09 pushed a commit to zer09/qmk_firmware that referenced this pull request Mar 31, 2019
slugger7 pushed a commit to slugger7/qmk_firmware that referenced this pull request Apr 3, 2019
@zvecr
Copy link
Member Author

zvecr commented Apr 20, 2019

Seems this is still producing errors, however now

{
	"message": "Error: westfoxtrot/aanzee: LAYOUT_iso: Number of elements in info.json does not match! info.json:68 != LAYOUT_iso:69",
	"severity": "error"
}, {
	"message": "Error: westfoxtrot/aanzee: LAYOUT_ansi: Number of elements in info.json does not match! info.json:68 != LAYOUT_ansi:69",
	"severity": "error"
}

Tracking this down, the info.json seems correct against all images of the board(assuming this is correct), and instead the LAYOUT macros have an extra key. It currently looks like the bottom row is configured for space, X, Y, Z, arrows while it should be space, X, Y, arrows, however i would only be able to guess which matrix position to edit.

Something like this for both the LAYOUT macros.

-  {K40, K41, K42, ___, ___, ___, K46, ___, ___, K49, K4A, K4B, K4C, K4D, K4E, ___}  \
+  {K40, K41, K42, ___, ___, ___, K46, ___, ___, K49, K4A, ___, K4C, K4D, K4E, ___}  \

@westfoxtrot Any ideas to what the layout/matrix should be?

@westfoxtrot
Copy link
Contributor

Seems this is still producing errors, however now

{
	"message": "Error: westfoxtrot/aanzee: LAYOUT_iso: Number of elements in info.json does not match! info.json:68 != LAYOUT_iso:69",
	"severity": "error"
}, {
	"message": "Error: westfoxtrot/aanzee: LAYOUT_ansi: Number of elements in info.json does not match! info.json:68 != LAYOUT_ansi:69",
	"severity": "error"
}

Tracking this down, the info.json seems correct against all images of the board(assuming this is correct), and instead the LAYOUT macros have an extra key. It currently looks like the bottom row is configured for space, X, Y, Z, arrows while it should be space, X, Y, arrows, however i would only be able to guess which matrix position to edit.

Something like this for both the LAYOUT macros.

-  {K40, K41, K42, ___, ___, ___, K46, ___, ___, K49, K4A, K4B, K4C, K4D, K4E, ___}  \
+  {K40, K41, K42, ___, ___, ___, K46, ___, ___, K49, K4A, ___, K4C, K4D, K4E, ___}  \

@westfoxtrot Any ideas to what the layout/matrix should be?

finally had a chance to go over this, as far as I can tell the issue is that indeed the layouts both have 69 keys rather than the matrix being wrong (additional ISO key & split backspace are in the configurator) I've submitted a fix for it, thanks so much for pointing it out!
@zvecr

dlhextall pushed a commit to dlhextall/qmk_firmware that referenced this pull request May 24, 2019
Timbus pushed a commit to Timbus/qmk_firmware that referenced this pull request Jun 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants