Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CXT Studio 12E3 keyboard #24749

Open
wants to merge 17 commits into
base: develop
Choose a base branch
from
Open

Add CXT Studio 12E3 keyboard #24749

wants to merge 17 commits into from
+167 −0

Conversation

muge
Copy link

@muge muge commented Dec 24, 2024

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

waffle87
waffle87 reviewed Dec 24, 2024
View reviewed changes
Copy link
Member

@waffle87 waffle87 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this PR depends on #24748 being merged first (ie. see current build failures), this will have to target develop branch instead. And will still fail until that's merged I suppose, so don't worry too much about what CI says.

keyboards/cxt_studio/12e3/keyboard.json Outdated Show resolved Hide resolved
keyboards/cxt_studio/12e3/rules.mk Outdated Show resolved Hide resolved
@muge muge changed the base branch from master to develop December 24, 2024 23:29
@waffle87 waffle87 added the awaiting_pr Relies on another PR to be merged first label Dec 24, 2024
@zvecr
Copy link
Member

zvecr commented Dec 26, 2024

With #24748 merged, could you rebase or merge upstream develop into your branch. That way we can hopefully resolve the CI failures for this PR.

@zvecr zvecr removed the awaiting_pr Relies on another PR to be merged first label Dec 26, 2024
@github-actions github-actions bot added the core label Dec 26, 2024
@zvecr zvecr removed the core label Dec 26, 2024
@muge muge requested a review from waffle87 December 30, 2024 18:39
@waffle87 waffle87 requested a review from a team December 30, 2024 20:52
zvecr
zvecr requested changes Dec 31, 2024
View reviewed changes
keyboards/cxt_studio/12e3/keyboard.json Outdated Show resolved Hide resolved
keyboards/cxt_studio/12e3/keyboard.json Outdated Show resolved Hide resolved
keyboards/cxt_studio/12e3/keyboard.json Outdated Show resolved Hide resolved
keyboards/cxt_studio/12e3/keyboard.json Outdated Show resolved Hide resolved
keyboards/cxt_studio/12e3/keyboard.json Outdated Show resolved Hide resolved
keyboards/cxt_studio/12e3/keymaps/default/keymap.c Outdated Show resolved Hide resolved
zvecr
zvecr requested changes Dec 31, 2024
View reviewed changes
keyboards/cxt_studio/12e3/readme.md Outdated Show resolved Hide resolved
@muge muge requested a review from zvecr December 31, 2024 11:29
@muge muge requested a review from zvecr December 31, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna left review comments

@waffle87 waffle87 waffle87 approved these changes

@zvecr zvecr Awaiting requested review from zvecr

Assignees
No one assigned
Labels
keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@muge @zvecr @drashna @waffle87