Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving cxt_studio keyboard to own folder #24748

Merged
merged 4 commits into from
Dec 26, 2024
Merged

Moving cxt_studio keyboard to own folder #24748

merged 4 commits into from
Dec 26, 2024

Conversation

muge
Copy link

@muge muge commented Dec 24, 2024

Description

  • Moving keyboard inhabiting cxt_studio to own folder, cxt_studio/12e4.
  • Updated mentions of the board's name in the readme.
  • Add alias to data/mappings/keyboard_aliases.hjson

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap dd Data Driven Changes labels Dec 24, 2024
@waffle87
Copy link
Member

There are also some additional changes I'd like to request.

  • This keyboard does not use RGB Light, so it is not right to use rgblight_xxx() function calls
    • Using the rgb_matrix_step() functions is probably better than manually handling this with a variable counter
  • Other naming tidy up

You can either make these changes manually yourself, or simply:

curl https://github.com/waffle87/qmk_firmware/commit/8d8b3810721640293ad6da29f86011c29fc53ef0.patch | git apply

@muge muge mentioned this pull request Dec 24, 2024
14 tasks
@waffle87 waffle87 requested a review from a team December 24, 2024 23:13
@zvecr zvecr merged commit 93de533 into qmk:develop Dec 26, 2024
2 checks passed
@muge muge deleted the 12e4 branch December 28, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dd Data Driven Changes keyboard keymap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants