Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set custom effect defines for LED Matrix #24745

Merged
merged 1 commit into from
Dec 24, 2024
Merged

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Dec 24, 2024

Description

RGB Matrix has the following block https://github.com/qmk/qmk_firmware/blob/master/builddefs/common_features.mk#L563-L569, but the equivalent block is missing for LED Matrix.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Dec 24, 2024
@zvecr zvecr added the bug label Dec 24, 2024
@drashna drashna merged commit a822545 into qmk:master Dec 24, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants