Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] LED_MATRIX_CUSTOM_KB and LED_MATRIX_CUSTOM_USER rules.mk variables don't trigger addition of necessary C/C++ defines #24743

Closed
2 tasks
yeroca opened this issue Dec 24, 2024 · 1 comment · Fixed by #24745

Comments

@yeroca
Copy link

yeroca commented Dec 24, 2024

Describe the Bug

When I set LED_MATRIX_CUSTOM_KB = true in my keyboard's rules.mk file, I do not get a corresponding C define generated in cflags.txt. When I look in all of the *.mk files in the tree, I don't see any use or definition for either of these two variables. I would have expected it to be in builddefs/common_features.mk which has the definition for LED_MATRIX_ENABLE.

I have worked around this temporarily by just adding a OPT_DEFS += -DLED_MATRIX_CUSTOM_KB to my keyboard's rules.mk.

Keyboard Used

Not keyboard specific

Link to product page (if applicable)

No response

Operating System

N/A

qmk doctor Output

No response

Is AutoHotKey / Karabiner installed

  • AutoHotKey (Windows)
  • Karabiner (macOS)

Other keyboard-related software installed

No response

Additional Context

I don't think this is related to a specific keyboard or OS, however I'm new here, so please forgive me if I've missed something obvious.

@yeroca
Copy link
Author

yeroca commented Dec 24, 2024

Thanks for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant