Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update keymaps to use PDF keycode #24633

Merged
merged 2 commits into from
Nov 23, 2024
Merged

Update keymaps to use PDF keycode #24633

merged 2 commits into from
Nov 23, 2024

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Nov 22, 2024 •
edited
Loading

Description

Update keymaps for #24630.

Convert simple use of set_single_persistent_default_layer(x) to PDF(x).

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr marked this pull request as ready for review November 23, 2024 10:13
@zvecr zvecr changed the title Update keymaps for 24630 Update keymaps to use PDF keycode Nov 23, 2024
daskygit
daskygit approved these changes Nov 23, 2024
View reviewed changes
Copy link
Member

@daskygit daskygit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've approved because the change is just a minor comment.

keyboards/handwired/ortho5x14/keymaps/default/keymap.c Outdated Show resolved Hide resolved
@zvecr zvecr merged commit e4e015c into qmk:develop Nov 23, 2024
3 checks passed
@zvecr zvecr deleted the 21881_keymaps_1 branch November 23, 2024 13:35
ilham-agustiawan pushed a commit to ilham-agustiawan/qmk_firmware that referenced this pull request Nov 30, 2024
@zvecr @ilham-agustiawan
Update keymaps to use PDF keycode (qmk#24633)
f42a79c
smallketchup82 pushed a commit to smallketchup82/qmk_firmware that referenced this pull request Dec 1, 2024
@zvecr @smallketchup82
Update keymaps to use PDF keycode (qmk#24633)
6b2b503
jlaptavi pushed a commit to jlaptavi/qmk_firmware that referenced this pull request Dec 3, 2024
@zvecr @jlaptavi
Update keymaps to use PDF keycode (qmk#24633)
9cbabfc
DmNosachev pushed a commit to DmNosachev/qmk_firmware that referenced this pull request Dec 7, 2024
@zvecr @DmNosachev
Update keymaps to use PDF keycode (qmk#24633)
3e18c7c
SyrupSplashin pushed a commit to SyrupSplashin/qmk_firmware that referenced this pull request Dec 10, 2024
@zvecr @SyrupSplashin
Update keymaps to use PDF keycode (qmk#24633)
ca021fc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daskygit daskygit daskygit approved these changes

Assignees
No one assigned
Labels
keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zvecr @daskygit