Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Add keycode PDF(layer) to set the default layer in EEPROM #24630

Merged
merged 3 commits into from
Nov 23, 2024
Merged

[Feature] Add keycode PDF(layer) to set the default layer in EEPROM #24630

merged 3 commits into from
Nov 23, 2024

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Nov 22, 2024 •
edited
Loading

Description

#21881 with merge conflicts resolved and aligned dd keycodes to latest develop.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr changed the title Merge 21881 [Feature] Add keycode PDF(layer) to set the default layer in EEPROM Nov 22, 2024
tzarc
tzarc requested changes Nov 22, 2024
View reviewed changes
quantum/pointing_device/pointing_device_auto_mouse.c Outdated Show resolved Hide resolved
tests/test_common/keycode_util.cpp Outdated Show resolved Hide resolved
@zvecr zvecr merged commit 4a5bae5 into develop Nov 23, 2024
7 checks passed
@zvecr zvecr deleted the develop_21881 branch November 23, 2024 10:09
@zvecr zvecr mentioned this pull request Nov 23, 2024
Merged
14 tasks
ilham-agustiawan pushed a commit to ilham-agustiawan/qmk_firmware that referenced this pull request Nov 30, 2024
@zvecr @Nebuleon
@tzarc @ilham-agustiawan
[Feature] Add keycode PDF(layer) to set the default layer in EEPROM (q…
cb69c8d 
…mk#24630)

* [Feature] Add keycode PDF(layer) to set the default layer in EEPROM (qmk#21881)

* Apply suggestions from code review

Co-authored-by: Nick Brassel <[email protected]>

---------

Co-authored-by: Nebuleon <[email protected]>
Co-authored-by: Nick Brassel <[email protected]>
smallketchup82 pushed a commit to smallketchup82/qmk_firmware that referenced this pull request Dec 1, 2024
@zvecr @Nebuleon
@tzarc @smallketchup82
[Feature] Add keycode PDF(layer) to set the default layer in EEPROM (q…
1f95c4c 
…mk#24630)

* [Feature] Add keycode PDF(layer) to set the default layer in EEPROM (qmk#21881)

* Apply suggestions from code review

Co-authored-by: Nick Brassel <[email protected]>

---------

Co-authored-by: Nebuleon <[email protected]>
Co-authored-by: Nick Brassel <[email protected]>
jlaptavi pushed a commit to jlaptavi/qmk_firmware that referenced this pull request Dec 3, 2024
@zvecr @Nebuleon
@tzarc @jlaptavi
[Feature] Add keycode PDF(layer) to set the default layer in EEPROM (q…
6917c24 
…mk#24630)

* [Feature] Add keycode PDF(layer) to set the default layer in EEPROM (qmk#21881)

* Apply suggestions from code review

Co-authored-by: Nick Brassel <[email protected]>

---------

Co-authored-by: Nebuleon <[email protected]>
Co-authored-by: Nick Brassel <[email protected]>
DmNosachev pushed a commit to DmNosachev/qmk_firmware that referenced this pull request Dec 7, 2024
@zvecr @Nebuleon
@tzarc @DmNosachev
[Feature] Add keycode PDF(layer) to set the default layer in EEPROM (q…
b0fdc0b 
…mk#24630)

* [Feature] Add keycode PDF(layer) to set the default layer in EEPROM (qmk#21881)

* Apply suggestions from code review

Co-authored-by: Nick Brassel <[email protected]>

---------

Co-authored-by: Nebuleon <[email protected]>
Co-authored-by: Nick Brassel <[email protected]>
SyrupSplashin pushed a commit to SyrupSplashin/qmk_firmware that referenced this pull request Dec 10, 2024
@zvecr @Nebuleon
@tzarc @SyrupSplashin
[Feature] Add keycode PDF(layer) to set the default layer in EEPROM (q…
750b3cf 
…mk#24630)

* [Feature] Add keycode PDF(layer) to set the default layer in EEPROM (qmk#21881)

* Apply suggestions from code review

Co-authored-by: Nick Brassel <[email protected]>

---------

Co-authored-by: Nebuleon <[email protected]>
Co-authored-by: Nick Brassel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

Assignees
No one assigned
Labels
core dd Data Driven Changes documentation enhancement keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zvecr @tzarc @Nebuleon