Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve cli.log.warn warnings #24551

Merged
merged 1 commit into from
Dec 15, 2024
Merged

Resolve cli.log.warn warnings #24551

merged 1 commit into from
Dec 15, 2024

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Oct 30, 2024 •
edited
Loading

Description

cli.log.warn was deprecated in Python 3.3.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added python cli qmk cli command labels Oct 30, 2024
@zvecr zvecr changed the title Resolve 'cli.log.warn' warnings Resolve cli.log.warn warnings Oct 30, 2024
@github-actions GitHub Actions
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Dec 15, 2024
@zvecr zvecr added awaiting review and removed stale Issues or pull requests that have become inactive without resolution. labels Dec 15, 2024
@tzarc tzarc merged commit 767dfbb into qmk:master Dec 15, 2024
5 checks passed
@zvecr zvecr deleted the cli_log_warn branch December 15, 2024 04:30
kevinpanaro pushed a commit to kevinpanaro/qmk_firmware that referenced this pull request Dec 18, 2024
@zvecr
Resolve cli.log.warn warnings (qmk#24551)
8614c2d
dpnetca pushed a commit to dpnetca/qmk_firmware that referenced this pull request Dec 22, 2024
@zvecr @dpnetca
Resolve cli.log.warn warnings (qmk#24551)
9c8975c
matoushybl pushed a commit to matoushybl/qmk_firmware that referenced this pull request Dec 22, 2024
@zvecr @matoushybl
Resolve cli.log.warn warnings (qmk#24551)
bdfb03c
ilham-agustiawan pushed a commit to ilham-agustiawan/qmk_firmware that referenced this pull request Dec 24, 2024
@zvecr @ilham-agustiawan
Resolve cli.log.warn warnings (qmk#24551)
33f8dc2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waffle87 waffle87 waffle87 approved these changes

@tzarc tzarc tzarc approved these changes

Assignees
No one assigned
Labels
awaiting review cli qmk cli command python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zvecr @tzarc @waffle87