Skip to content

Commit

Permalink
Resolve cli.log.warn warnings (qmk#24551)
Browse files Browse the repository at this point in the history
  • Loading branch information
zvecr authored and Kevin Panaro committed Dec 18, 2024
1 parent 5c7db72 commit 8614c2d
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
6 changes: 3 additions & 3 deletions lib/python/qmk/cli/doctor/main.py
Original file line number Diff line number Diff line change
Expand Up @@ -102,10 +102,10 @@ def userspace_tests(qmk_firmware):
qmk_userspace_validate(path)
cli.log.info(f'Testing userspace candidate: {{fg_cyan}}{path}{{fg_reset}} -- {{fg_green}}Valid `qmk.json`')
except FileNotFoundError:
cli.log.warn(f'Testing userspace candidate: {{fg_cyan}}{path}{{fg_reset}} -- {{fg_red}}Missing `qmk.json`')
cli.log.warning(f'Testing userspace candidate: {{fg_cyan}}{path}{{fg_reset}} -- {{fg_red}}Missing `qmk.json`')
except UserspaceValidationError as err:
cli.log.warn(f'Testing userspace candidate: {{fg_cyan}}{path}{{fg_reset}} -- {{fg_red}}Invalid `qmk.json`')
cli.log.warn(f' -- {{fg_cyan}}{path}/qmk.json{{fg_reset}} validation error: {err}')
cli.log.warning(f'Testing userspace candidate: {{fg_cyan}}{path}{{fg_reset}} -- {{fg_red}}Invalid `qmk.json`')
cli.log.warning(f' -- {{fg_cyan}}{path}/qmk.json{{fg_reset}} validation error: {err}')

if QMK_USERSPACE is not None:
cli.log.info(f'QMK userspace: {{fg_cyan}}{QMK_USERSPACE}')
Expand Down
2 changes: 1 addition & 1 deletion lib/python/qmk/cli/import/kbfirmware.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ def import_kbfirmware(cli):
cli.log.info(f'{{style_bright}}Importing {filename.name}.{{style_normal}}')
cli.echo('')

cli.log.warn("Support here is basic - Consider using 'qmk new-keyboard' instead")
cli.log.warning("Support here is basic - Consider using 'qmk new-keyboard' instead")

kb_name = _import_kbfirmware(data)

Expand Down
2 changes: 1 addition & 1 deletion lib/python/qmk/cli/userspace/list.py
Original file line number Diff line number Diff line change
Expand Up @@ -66,4 +66,4 @@ def userspace_list(cli):
if is_all_keyboards(keyboard) or is_keymap_target(keyboard_folder(keyboard), keymap):
cli.log.info(f'Keyboard: {{fg_cyan}}{keyboard}{{fg_reset}}, keymap: {{fg_cyan}}{keymap}{{fg_reset}}{extra_args_str}')
else:
cli.log.warn(f'Keyboard: {{fg_cyan}}{keyboard}{{fg_reset}}, keymap: {{fg_cyan}}{keymap}{{fg_reset}}{extra_args_str} -- not found!')
cli.log.warning(f'Keyboard: {{fg_cyan}}{keyboard}{{fg_reset}}, keymap: {{fg_cyan}}{keymap}{{fg_reset}}{extra_args_str} -- not found!')
2 changes: 1 addition & 1 deletion lib/python/qmk/git.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ def git_get_version(repo_dir='.', check_dir='.'):
return git_describe.stdout.strip()

else:
cli.log.warn(f'"{" ".join(git_describe_cmd)}" returned error code {git_describe.returncode}')
cli.log.warning(f'"{" ".join(git_describe_cmd)}" returned error code {git_describe.returncode}')
print(git_describe.stderr)
return None

Expand Down

0 comments on commit 8614c2d

Please sign in to comment.