Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qmk new-keyboard: separate dev board and MCU selection #24548

Merged
merged 3 commits into from
Nov 21, 2024

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented Oct 30, 2024

Description

Instead of lumping everything into a giant list, we ask the user if their new keyboard project utilises a development board such as a Pro Micro, or has the microcontroller directly on the same PCB, then show the appropriate list. This has caused confusion for users in the past where they select eg. the bare RP2040 option when they are in fact using a particular RP2040-based devboard.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team October 30, 2024 04:15
@fauxpark
Copy link
Member Author

Porting docs have been updated to reflect current new-keyboard output, and tweaked some of it a little. I'll try to revisit more thoroughly later.

@tzarc tzarc merged commit 638b22d into qmk:develop Nov 21, 2024
6 checks passed
@fauxpark fauxpark deleted the new-keyboard-separate-devboard-mcu branch November 21, 2024 08:50
ilham-agustiawan pushed a commit to ilham-agustiawan/qmk_firmware that referenced this pull request Nov 30, 2024
smallketchup82 pushed a commit to smallketchup82/qmk_firmware that referenced this pull request Dec 1, 2024
jlaptavi pushed a commit to jlaptavi/qmk_firmware that referenced this pull request Dec 3, 2024
DmNosachev pushed a commit to DmNosachev/qmk_firmware that referenced this pull request Dec 7, 2024
SyrupSplashin pushed a commit to SyrupSplashin/qmk_firmware that referenced this pull request Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants