Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add KBDCraft Adam64 Lego board #20503

Merged
merged 25 commits into from
Apr 23, 2023
Merged

Add KBDCraft Adam64 Lego board #20503

merged 25 commits into from
Apr 23, 2023

Conversation

adophoxia
Copy link
Contributor

Description

As title.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • N/A

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Apr 19, 2023
zvecr
zvecr requested changes Apr 19, 2023
View reviewed changes
keyboards/kbdcraft/adam64/info.json Outdated Show resolved Hide resolved
keyboards/kbdcraft/adam64/info.json Outdated Show resolved Hide resolved
keyboards/kbdcraft/adam64/mcuconf.h Outdated Show resolved Hide resolved
keyboards/kbdcraft/adam64/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/kbdcraft/adam64/adam64.c Show resolved Hide resolved
keyboards/kbdcraft/adam64/adam64.c Outdated Show resolved Hide resolved
@adophoxia adophoxia requested a review from zvecr April 19, 2023 04:10
lesshonor
lesshonor suggested changes Apr 19, 2023
View reviewed changes
Copy link
Contributor

@lesshonor lesshonor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to run qmk info -m -kb kbdcraft/adam64 to double-check the appearance of the keyboard. (...alternately/in addition, upload your info.json to QMK Configurator with Shift+Ctrl+I)

keyboards/kbdcraft/adam64/info.json Show resolved Hide resolved
keyboards/kbdcraft/adam64/info.json Outdated Show resolved Hide resolved
keyboards/kbdcraft/adam64/config.h Outdated Show resolved Hide resolved
keyboards/kbdcraft/adam64/info.json Outdated Show resolved Hide resolved
keyboards/kbdcraft/adam64/info.json Outdated Show resolved Hide resolved
keyboards/kbdcraft/adam64/readme.md Outdated Show resolved Hide resolved
@adophoxia
Copy link
Contributor Author

Turns out I mistakenly used the 60_ansi_arrow layout since I assumed that it was just another alias for 64_ansi, which aren't the same, so I updated to use the correct layout.

This was referenced Apr 20, 2023
Merged
Merged
@drashna drashna requested a review from a team April 22, 2023 08:15
@adophoxia adophoxia requested a review from waffle87 April 23, 2023 19:04
@waffle87 waffle87 merged commit 713427c into qmk:master Apr 23, 2023
stratosgear pushed a commit to stratosgear/qmk_firmware that referenced this pull request Apr 26, 2023
@adophoxia @lesshonor
@waffle87 @stratosgear
Add KBDCraft Adam64 Lego board (qmk#20503)
b192583 
Co-authored-by: Less/Rikki <[email protected]>
Co-authored-by: jack <[email protected]>
struckmb pushed a commit to struckmb/qmk_firmware that referenced this pull request May 1, 2023
@adophoxia @lesshonor
@waffle87 @struckmb
Add KBDCraft Adam64 Lego board (qmk#20503)
63fd7dc 
Co-authored-by: Less/Rikki <[email protected]>
Co-authored-by: jack <[email protected]>
rodrigob pushed a commit to rodrigob/qmk_firmware that referenced this pull request May 2, 2023
@adophoxia @lesshonor
@waffle87 @rodrigob
Add KBDCraft Adam64 Lego board (qmk#20503)
7999f53 
Co-authored-by: Less/Rikki <[email protected]>
Co-authored-by: jack <[email protected]>
barrettclark added a commit to barrettclark/qmk_firmware that referenced this pull request May 4, 2023
@barrettclark
Merge remote-tracking branch 'upstream/master'
1b9821e 
* upstream/master: (46 commits)
  [Keyboard] Add 1upkeyboards pi50 (qmk#20242)
  `sofle/via` encoder map & doc handedness update (qmk#20630)
  [Keyboard] add phantagom/baragon marcopad (qmk#20543)
  [Keyboard] add phantagom/varan rgb numpad (qmk#20587)
  [Keymap] Small changes to fix failing karn keyboard build (qmk#20618)
  Repair Spleeb i2c config and chrishoage keymap (qmk#20644)
  Adding my keymap (qmk#20345)
  Add additional options for Drag Scroll config (qmk#20523)
  Added Velvet Hotswap and Solder PCBs (qmk#20510)
  [Keyboard] Add the Aster Ergo PCB (qmk#20513)
  vertex/angle65 - Implement RGBlight (qmk#20514)
  [Keymap update] Keymap & docs update (qmk#20298)
  Fix MATRIX_HAS_GHOST when MATRIX_COL > 16 (qmk#20093)
  ez_maker/directpins/promicro: Fix bootloader mismatch (qmk#20627)
  Fix up positioning of keys for Keychron Q10/V10 and Q6/V6 (qmk#20582)
  [Keymap] Add johnstegeman iris colemak keymap (qmk#20575)
  [Keyboard] Add Manibus VIA support (qmk#20497)
  Add KBDCraft Adam64 Lego board (qmk#20503)
  Update code example to match description (qmk#20528)
  NK Plus (qmk#20392)
  ...
jiaxin96 pushed a commit to Oh-My-Mechanical-Keyboard/qmk_firmware that referenced this pull request Oct 18, 2023
@adophoxia @lesshonor
Add KBDCraft Adam64 to VIAL (qmk#446)
f031809 
* Add `KBDCraft Adam64` to VIAL

* Sync changes from `qmk#20503`

* Have `make` command example in `readme.md` use `vial` keymap

* Add in new `VIAL_KEYBOARD_UID`

* Update keyboards/kbdcraft/adam64/readme.md

Co-authored-by: Less/Rikki <[email protected]>

---------

Co-authored-by: Less/Rikki <[email protected]>
autoferrit pushed a commit to SpaceRockMedia/bastardkb-qmk that referenced this pull request Dec 8, 2023
@adophoxia @lesshonor
@waffle87 @autoferrit
Add KBDCraft Adam64 Lego board (qmk#20503)
e1babe7 
Co-authored-by: Less/Rikki <[email protected]>
Co-authored-by: jack <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lesshonor lesshonor lesshonor requested changes

@waffle87 waffle87 waffle87 approved these changes

@drashna drashna drashna approved these changes

@zvecr zvecr Awaiting requested review from zvecr

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@adophoxia @drashna @zvecr @waffle87 @lesshonor