NK Plus #20392
Merged
NK Plus #20392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
keyboard
keymap
via
elpekenin
suggested changes
Apr 9, 2023
Co-authored-by: Pablo Martínez <[email protected]>
|
em how did the ci fail on the other ones? any help? |
elpekenin
reviewed
Apr 10, 2023
There was a problem hiding this comment.
imo it makes more sense moving this to keyboards/novelkeys/nk_plus/keymaps/via/readme.md
There was a problem hiding this comment.
Also, this is probably why it triggered the odd CI checks
No idea about how the CI code works, but since you havent edited those, my first bets would be
|
drashna
approved these changes
Apr 12, 2023
fauxpark
reviewed
Apr 12, 2023
keyboard-magpie
approved these changes
Apr 21, 2023
stratosgear
pushed a commit
to stratosgear/qmk_firmware
that referenced
this pull request
Apr 26, 2023
barrettclark
added a commit
to barrettclark/qmk_firmware
that referenced
this pull request
May 4, 2023
* upstream/master: (46 commits) [Keyboard] Add 1upkeyboards pi50 (qmk#20242) `sofle/via` encoder map & doc handedness update (qmk#20630) [Keyboard] add phantagom/baragon marcopad (qmk#20543) [Keyboard] add phantagom/varan rgb numpad (qmk#20587) [Keymap] Small changes to fix failing karn keyboard build (qmk#20618) Repair Spleeb i2c config and chrishoage keymap (qmk#20644) Adding my keymap (qmk#20345) Add additional options for Drag Scroll config (qmk#20523) Added Velvet Hotswap and Solder PCBs (qmk#20510) [Keyboard] Add the Aster Ergo PCB (qmk#20513) vertex/angle65 - Implement RGBlight (qmk#20514) [Keymap update] Keymap & docs update (qmk#20298) Fix MATRIX_HAS_GHOST when MATRIX_COL > 16 (qmk#20093) ez_maker/directpins/promicro: Fix bootloader mismatch (qmk#20627) Fix up positioning of keys for Keychron Q10/V10 and Q6/V6 (qmk#20582) [Keymap] Add johnstegeman iris colemak keymap (qmk#20575) [Keyboard] Add Manibus VIA support (qmk#20497) Add KBDCraft Adam64 Lego board (qmk#20503) Update code example to match description (qmk#20528) NK Plus (qmk#20392) ...
SjB
added a commit
to SjB/qmk_firmware
that referenced
this pull request
May 12, 2023
* master: NK Plus (qmk#20392) [Docs] Fix suggested code pattern when a specific mod-mask is required. (qmk#20512) [Docs] Remove combo count from array (qmk#20511) Add QuadrumLabs Delta (qmk#20409) Adds Docs option for ArduinoIDE's example `ArduinoISP` (qmk#20486) GMMK 2 volume up/down Fn keys are backwards in default mapping (qmk#20476) Fix typo in `feature_wpm.md` title (qmk#20464) [Keyboard] Add Kalakos Bahrnob65 (qmk#20424) Tidy up stray RGB_DISABLE_TIMEOUT references (qmk#20460) [Keyboard] Add zoom75 wired (qmk#20396) [Keyboard] Add dymium65 (qmk#20257) Lotus58 glow (qmk#20386) ADPenrose Obi Layout Macro Conversion and Addition (qmk#20445)
autoferrit
pushed a commit
to SpaceRockMedia/bastardkb-qmk
that referenced
this pull request
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the NK Plus:)
Types of Changes
Issues Fixed or Closed by This PR
Checklist