Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added hackpad keyboard #20402

Merged
merged 10 commits into from
Jul 4, 2023
Merged

added hackpad keyboard #20402

merged 10 commits into from
Jul 4, 2023

Conversation

ThePurox
Copy link
Contributor

Description

I've designed a 4x4 numpad/macropad with an rotary encoder and per key RGB-LEDs.
It is designed for a workshop at the local Arduino Day in Bayreuth Germany about mechanical keyboards.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

keyboards/hackpad/config.h Outdated Show resolved Hide resolved
keyboards/hackpad/rules.mk Outdated Show resolved Hide resolved
@ThePurox
Copy link
Contributor Author

It builds fine on my machine. Does someone know how to fix the CI Build failure? pin is defined in info.json, but the CI complaines that WS2812_DI_PIN is undeclared.

keyboards/hackpad/info.json Outdated Show resolved Hide resolved
keyboards/hackpad/info.json Outdated Show resolved Hide resolved
keyboards/hackpad/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/hackpad/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/hackpad/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/hackpad/config.h Outdated Show resolved Hide resolved
keyboards/hackpad/info.json Outdated Show resolved Hide resolved
keyboards/hackpad/info.json Outdated Show resolved Hide resolved
keyboards/hackpad/readme.md Outdated Show resolved Hide resolved
@ThePurox ThePurox requested review from elpekenin and sigprof April 10, 2023 20:07
keyboards/hackpad/info.json Outdated Show resolved Hide resolved
keyboards/hackpad/info.json Outdated Show resolved Hide resolved
keyboards/hackpad/info.json Outdated Show resolved Hide resolved
keyboards/hackpad/info.json Outdated Show resolved Hide resolved
@ThePurox
Copy link
Contributor Author

Is there anything left to do to get this PR merged?

@waffle87 waffle87 requested review from a team and removed request for elpekenin May 13, 2023 06:40
@@ -0,0 +1,31 @@
# hackpad

![hackpad](https://git.imaginaerraum.de/Purox/Hackpad/src/branch/main/pic.jpg)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dead link.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed by the newest commit.
Thank you for noticing!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still doesn't work.
image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the annoyance.. Now the link points to the raw image, and the image is previewed.

keyboards/hackpad/info.json Outdated Show resolved Hide resolved
keyboards/hackpad/info.json Outdated Show resolved Hide resolved
keyboards/hackpad/info.json Outdated Show resolved Hide resolved
keyboards/hackpad/info.json Outdated Show resolved Hide resolved
keyboards/hackpad/info.json Outdated Show resolved Hide resolved
@@ -0,0 +1,31 @@
# hackpad

![hackpad](https://git.imaginaerraum.de/Purox/Hackpad/raw/branch/main/assets/pic.jpg)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rehost this on imgur, or reduce the size to ~1000px.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@drashna drashna requested a review from a team July 4, 2023 01:35
@waffle87 waffle87 merged commit 01920b2 into qmk:develop Jul 4, 2023
jesperhellberg pushed a commit to jesperhellberg/qmk_firmware that referenced this pull request Sep 9, 2023
Co-authored-by: Sergey Vlasov <[email protected]>
Co-authored-by: Joel Challis <[email protected]>
Co-authored-by: Ryan <[email protected]>
Co-authored-by: Nico Stuhlmueller <[email protected]>
Co-authored-by: jack <[email protected]>
thismarvin pushed a commit to thismarvin/qmk_firmware that referenced this pull request Sep 27, 2023
Co-authored-by: Sergey Vlasov <[email protected]>
Co-authored-by: Joel Challis <[email protected]>
Co-authored-by: Ryan <[email protected]>
Co-authored-by: Nico Stuhlmueller <[email protected]>
Co-authored-by: jack <[email protected]>
akeep pushed a commit to akeep/qmk_firmware that referenced this pull request Oct 2, 2023
Co-authored-by: Sergey Vlasov <[email protected]>
Co-authored-by: Joel Challis <[email protected]>
Co-authored-by: Ryan <[email protected]>
Co-authored-by: Nico Stuhlmueller <[email protected]>
Co-authored-by: jack <[email protected]>
csolje pushed a commit to csolje/qmk_firmware that referenced this pull request Oct 21, 2023
Co-authored-by: Sergey Vlasov <[email protected]>
Co-authored-by: Joel Challis <[email protected]>
Co-authored-by: Ryan <[email protected]>
Co-authored-by: Nico Stuhlmueller <[email protected]>
Co-authored-by: jack <[email protected]>
jashort pushed a commit to jashort/qmk_firmware that referenced this pull request Nov 20, 2023
Co-authored-by: Sergey Vlasov <[email protected]>
Co-authored-by: Joel Challis <[email protected]>
Co-authored-by: Ryan <[email protected]>
Co-authored-by: Nico Stuhlmueller <[email protected]>
Co-authored-by: jack <[email protected]>
autoferrit pushed a commit to SpaceRockMedia/bastardkb-qmk that referenced this pull request Dec 8, 2023
Co-authored-by: Sergey Vlasov <[email protected]>
Co-authored-by: Joel Challis <[email protected]>
Co-authored-by: Ryan <[email protected]>
Co-authored-by: Nico Stuhlmueller <[email protected]>
Co-authored-by: jack <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants