Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Joel Challis <[email protected]>
  • Loading branch information
2 people authored and Nico Stuhlmueller committed Apr 11, 2023
1 parent 62e7b79 commit 1b407f3
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 8 deletions.
2 changes: 0 additions & 2 deletions keyboards/hackpad/hackpad.c
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
// Copyright 2023 Nico Stuhlmueller (@ThePurox)
// SPDX-License-Identifier: GPL-2.0-or-later

#include QMK_KEYBOARD_H

bool encoder_update_kb(uint8_t index, bool clockwise) {
if (clockwise) {
tap_code_delay(KC_VOLU, 10);
Expand Down
8 changes: 2 additions & 6 deletions keyboards/hackpad/info.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,11 @@
"development_board": "promicro",
"diode_direction": "COL2ROW",
"features": {
"bootmagic": false,
"bootmagic": true,
"command": false,
"console": false,
"extrakey": true,
"mousekey": false,
"mousekey": true,
"nkro": true,
"rgblight": true,
"encoder" : true
Expand All @@ -34,10 +34,6 @@
},
"rgblight" : {
"led_count" : 16,
"hue_steps" : 20,
"brightness_steps" : 10,
"saturation_steps" : 20,
"max_brightness" : 255,
"sleep" : true,
"animations": {
"breathing" : true,
Expand Down

0 comments on commit 1b407f3

Please sign in to comment.