Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand on the differences between Caps Word and Caps Lock #18139

Merged
merged 3 commits into from
Aug 30, 2022
Merged

Expand on the differences between Caps Word and Caps Lock #18139

merged 3 commits into from
Aug 30, 2022

Conversation

precondition
Copy link
Contributor

Description

Provide more information about the differences between the behaviour of Caps Lock and Caps Word when it comes to what keys get capitalized/shifted. This is especially addressed to users of international OS keyboard layouts.

Inspired by #18136 and #18137

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

mmccoyd
mmccoyd reviewed Aug 22, 2022
View reviewed changes
Copy link
Contributor

@mmccoyd mmccoyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps highlight running on the keyboard causes the OS keyboard mismatch.

"
unxepected ways.
Especially when using an OS keyboard layout other than US or UK,
as CAPS_WORD affects only the keyboard.
"

@precondition precondition force-pushed the caps_word_is_not_caps_lock branch from 59608d7 to 8b6f2f6 Compare August 22, 2022 23:56
@precondition precondition force-pushed the caps_word_is_not_caps_lock branch from 8b6f2f6 to 7bfb8f1 Compare August 22, 2022 23:59
@drashna drashna requested a review from a team August 23, 2022 01:23
KarlK90
KarlK90 approved these changes Aug 30, 2022
View reviewed changes
Copy link
Member

@KarlK90 KarlK90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for expanding the explanation, reads really well!

@KarlK90 KarlK90 merged commit 6f2c173 into qmk:master Aug 30, 2022
@precondition precondition deleted the caps_word_is_not_caps_lock branch October 5, 2022 07:59
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@precondition @nolanseaton
Expand on the differences between Caps Word and Caps Lock (qmk#18139)
e2762fb 
* Expand on the differences between Caps Word and Caps Lock

* Add the equiv default KC_ next to intl alias

* It's configurable so it's not a problem
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmccoyd mmccoyd mmccoyd left review comments

@KarlK90 KarlK90 KarlK90 approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@precondition @drashna @mmccoyd @KarlK90