Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] CAPS_WORD '-' produces '_' #18137

Merged
merged 5 commits into from
Oct 4, 2022
Merged

[Docs] CAPS_WORD '-' produces '_' #18137

merged 5 commits into from
Oct 4, 2022

Conversation

mmccoyd
Copy link
Contributor

@mmccoyd mmccoyd commented Aug 22, 2022

Description

Clarify docs that minus becomes underscore.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Fixes documentation issue related to:

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@mmccoyd mmccoyd marked this pull request as draft August 22, 2022 22:19
@mmccoyd mmccoyd marked this pull request as ready for review August 22, 2022 22:26
@precondition precondition mentioned this pull request Aug 22, 2022
Merged
14 tasks
@drashna drashna requested a review from a team August 28, 2022 17:17
spidey3
spidey3 reviewed Aug 29, 2022
View reviewed changes
docs/feature_caps_word.md Outdated Show resolved Hide resolved
@drashna drashna merged commit 78c4907 into qmk:master Oct 4, 2022
4pplet added a commit to 4pplet/qmk_firmware that referenced this pull request Oct 4, 2022
@4pplet
Squashed commit of the following:
36c474b 
commit daf2552bdb579376ea13f467c3c1bac07e6a99a4
Author: 4pplet <[email protected]>
Date:   Tue Oct 4 11:52:04 2022 +0200

    cont

commit fa252981fb61fd9f1e5d46846266291de6a7e19d
Merge: 135153a7a4 78c4907
Author: 4pplet <[email protected]>
Date:   Tue Oct 4 11:49:15 2022 +0200

    Merge remote-tracking branch 'upstream/master' into waffling80_rev_b

commit 135153a7a417cb7cc3725b43eeb22287f251bc6e
Merge: ed74dbe24b 9ebb5a7bb3
Author: 4pplet <[email protected]>
Date:   Tue Oct 4 11:48:27 2022 +0200

    Merge branch 'waffling80_rev_b' of https://github.com/4pplet/qmk_firmware into waffling80_rev_b

commit ed74dbe24bf7918898d1c3193f7c36115644eace
Author: 4pplet <[email protected]>
Date:   Tue Oct 4 11:45:34 2022 +0200

    cont

commit 78c4907
Author: mmccoyd <[email protected]>
Date:   Mon Oct 3 19:17:08 2022 -0700

    [Docs] Clarify CAPS_WORD behaviors (qmk#18137)

    Co-authored-by: precondition <[email protected]>
    Co-authored-by: mmccoyd <[email protected]>
    Co-authored-by: Drashna Jaelre <[email protected]>

commit dc52347
Author: Brian Choromanski <[email protected]>
Date:   Mon Oct 3 21:42:56 2022 -0400

    Added new issue templates for feature requests and bug reports (qmk#18576)

    Co-authored-by: Ryan <[email protected]>

commit 88046b3
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Tue Oct 4 08:51:57 2022 +1100

    Bump anothrNick/github-tag-action from 1.50.0 to 1.51.0 (qmk#18575)

    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit 9ebb5a7bb329b1fe9a4d0091b61e1da94f0ffcc9
Author: 4pplet <[email protected]>
Date:   Mon Oct 3 22:14:13 2022 +0200

    cont

commit 079fc7a256d459ffab2e2c01d0ca1a287acc4e2e
Author: 4pplet <[email protected]>
Date:   Mon Oct 3 16:03:32 2022 +0200

    Update rev_b.h

commit e59f731f62fc9db26351d7552054c49ec7ea7649
Author: 4pplet <[email protected]>
Date:   Wed Sep 21 22:36:36 2022 +0200

    cont, compiles properly, not tested on HW

commit 658b9afa374f485dee7245495747140361e9c48d
Author: 4pplet <[email protected]>
Date:   Wed Sep 21 22:21:10 2022 +0200

    Update mcuconf.h

commit c4dc3944967917501ddf7e3dba0786072aa28604
Merge: 343666ad7f ee22f34
Author: 4pplet <[email protected]>
Date:   Wed Sep 21 22:20:57 2022 +0200

    Merge remote-tracking branch 'upstream/master' into waffling80_rev_b

commit 343666ad7f0e1ea894beac9dc72ae4d4d496af61
Author: 4pplet <[email protected]>
Date:   Wed Sep 21 19:45:06 2022 +0200

    adding draft for rev_b
@mmccoyd mmccoyd deleted the capsword_doc branch October 17, 2022 04:57
quinnyo pushed a commit to quinnyo/qmk_firmware that referenced this pull request Oct 21, 2022
@mmccoyd @precondition
@drashna @quinnyo
[Docs] Clarify CAPS_WORD behaviors (qmk#18137)
b1e3158 
Co-authored-by: precondition <[email protected]>
Co-authored-by: mmccoyd <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
aivalja pushed a commit to aivalja/qmk_firmware that referenced this pull request Nov 7, 2022
@mmccoyd @precondition @drashna
[Docs] Clarify CAPS_WORD behaviors (qmk#18137)
024015c 
Co-authored-by: precondition <[email protected]>
Co-authored-by: mmccoyd <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@mmccoyd @precondition
@drashna @ramonimbao
[Docs] Clarify CAPS_WORD behaviors (qmk#18137)
6b7a317 
Co-authored-by: precondition <[email protected]>
Co-authored-by: mmccoyd <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@mmccoyd @precondition
@drashna @nolanseaton
[Docs] Clarify CAPS_WORD behaviors (qmk#18137)
f81eb14 
Co-authored-by: precondition <[email protected]>
Co-authored-by: mmccoyd <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@precondition precondition precondition left review comments

@spidey3 spidey3 spidey3 left review comments

@drashna drashna drashna approved these changes

@keyboard-magpie keyboard-magpie keyboard-magpie approved these changes

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mmccoyd @drashna @keyboard-magpie @spidey3 @precondition