Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rgbkb/keeb fixes #17932

Merged
merged 4 commits into from
Aug 7, 2022
Merged

Rgbkb/keeb fixes #17932

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7013d69
Disable console by default for better bios & reboot behavior
XScorpion2 Aug 6, 2022
1202e8f
Remove custom matrix
XScorpion2 Aug 6, 2022
45f28f8
Disable console by default for better bios & reboot behavior
XScorpion2 Aug 6, 2022
a4949db
PR feedback
XScorpion2 Aug 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion keyboards/rgbkb/common/common_oled.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@
#include "oled_driver.h"
#include "rgb_matrix.h"

// for memcpy
// for memcpy & snprintf
#include <stdio.h>
#include <string.h>
#include <transactions.h>

Expand Down
76 changes: 0 additions & 76 deletions keyboards/rgbkb/mun/matrix.c
View file
Open in desktop

This file was deleted.

5 changes: 1 addition & 4 deletions keyboards/rgbkb/mun/rules.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ QUANTUM_LIB_SRC += i2c_master.c
BOOTMAGIC_ENABLE = no # Enable Bootmagic Lite
MOUSEKEY_ENABLE = no # Mouse keys
EXTRAKEY_ENABLE = yes # Audio control and System control
CONSOLE_ENABLE = yes # Console for debug
CONSOLE_ENABLE = no # Console for debug
COMMAND_ENABLE = no # Commands for debug and configuration
NKRO_ENABLE = yes # Enable N-Key Rollover
AUDIO_ENABLE = no # Audio output
Expand All @@ -38,7 +38,4 @@ OPT = 3

OPT_DEFS += -DOLED_FONT_H=\"keyboards/rgbkb/common/glcdfont.c\"

# matrix optimisations
SRC += matrix.c

DEFAULT_FOLDER = rgbkb/mun/rev1
6 changes: 1 addition & 5 deletions keyboards/rgbkb/sol3/rules.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ QUANTUM_LIB_SRC += i2c_master.c
BOOTMAGIC_ENABLE = yes # Enable Bootmagic Lite
MOUSEKEY_ENABLE = no # Mouse keys
EXTRAKEY_ENABLE = yes # Audio control and System control
CONSOLE_ENABLE = yes # Console for debug
CONSOLE_ENABLE = no # Console for debug
COMMAND_ENABLE = no # Commands for debug and configuration
NKRO_ENABLE = yes # Enable N-Key Rollover
AUDIO_ENABLE = yes # Audio output
Expand All @@ -42,8 +42,4 @@ OPT = 3

OPT_DEFS += -DOLED_FONT_H=\"keyboards/rgbkb/common/glcdfont.c\"

# TODO: Implement fast matrix scanning
# matrix optimisations
# SRC += matrix.c

DEFAULT_FOLDER = rgbkb/sol3/rev1