Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rgbkb/keeb fixes #17932

Merged
merged 4 commits into from
Aug 7, 2022
Merged

Rgbkb/keeb fixes #17932

merged 4 commits into from
Aug 7, 2022

Conversation

XScorpion2
Copy link
Contributor

Description

Small changes to update Mun & Sol 3 for latest QMK Master compatibility.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • Fixed compile issue when CONSOLE_ENABLE = no
  • Set CONSOLE_ENABLE = no as default for improved BIOS compatibility
  • Removed custom matrix for Mun as it's no longer compatible with QMK Master changes

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr requested a review from a team August 6, 2022 17:23
fauxpark
fauxpark requested changes Aug 6, 2022
View reviewed changes
keyboards/rgbkb/common/common_oled.c Outdated Show resolved Hide resolved
@XScorpion2 XScorpion2 requested a review from fauxpark August 6, 2022 20:31
@zvecr zvecr merged commit 034e266 into qmk:master Aug 7, 2022
imhoffman pushed a commit to imhoffman/qmk_firmware that referenced this pull request Aug 20, 2022
@XScorpion2 @imhoffman
Rgbkb/keeb fixes (qmk#17932)
c6a396d 
* Disable console by default for better bios & reboot behavior

* Remove custom matrix

* Disable console by default for better bios & reboot behavior

* PR feedback
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@XScorpion2 @nolanseaton
Rgbkb/keeb fixes (qmk#17932)
cb577dc 
* Disable console by default for better bios & reboot behavior

* Remove custom matrix

* Disable console by default for better bios & reboot behavior

* PR feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

@drashna drashna drashna approved these changes

@fauxpark fauxpark Awaiting requested review from fauxpark

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@XScorpion2 @drashna @fauxpark @zvecr