Re-add call to suspend_power_down_kb().
#16382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drashna
approved these changes
Feb 17, 2022
fauxpark
approved these changes
Feb 17, 2022
In qmk#14210, all previous calls to `suspend_power_down_kb()` were replaced with calls to `suspend_power_down_quantum()`, together with some much needed deduplication. However, the `_kb` function was never called from the `_quantum` one (unlike `suspend_wakeup_init_kb()`). I followed the example of how it was implemented for AVR before qmk#14210, i.e. called before the rest of the suspend functions, regardless of the `NO_SUSPEND_POWER_DOWN` setting. Fixes qmk#16279.
firetech
force-pushed
the
readd_suspend_power_down_kb_call
branch
from
f118593 to
a45b2b9
Compare
|
I force-pushed a minor change to the commit message (noticed a mistake there, same mistake was in the PR description), the code is untouched. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #14210, all previous calls to
suspend_power_down_kb()were replaced with calls tosuspend_power_down_quantum(), together with some much needed deduplication. However, the_kbfunction was never called from the_quantumone (unlikesuspend_wakeup_init_kb()).I followed the example of how it was implemented for AVR before #14210, i.e. called before the rest of the suspend functions, regardless of the
NO_SUSPEND_POWER_DOWNsetting.Types of Changes
Issues Fixed or Closed by This PR
Checklist