Move feature suspend logic out of platform specific code #14210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zvecr
approved these changes
Aug 30, 2021
firetech
added a commit
to firetech/qmk_firmware
that referenced
this pull request
Feb 16, 2022
In qmk#14210, all previous calls to `suspend_power_down_kb()` were replaced with calls to `suspend_power_down_quantum()`, together with some much needed deduplication. However, the `_kb` function was never called from the `_quantum` one (unlike `suspend_power_down_kb()`). I followed the example of how it was implemented for AVR before qmk#14210, i.e. called before the rest of the suspend functions, regardless of the `NO_SUSPEND_POWER_DOWN` setting. Fixes qmk#16279.
14 tasks
firetech
added a commit
to firetech/qmk_firmware
that referenced
this pull request
Feb 17, 2022
In qmk#14210, all previous calls to `suspend_power_down_kb()` were replaced with calls to `suspend_power_down_quantum()`, together with some much needed deduplication. However, the `_kb` function was never called from the `_quantum` one (unlike `suspend_wakeup_init_kb()`). I followed the example of how it was implemented for AVR before qmk#14210, i.e. called before the rest of the suspend functions, regardless of the `NO_SUSPEND_POWER_DOWN` setting. Fixes qmk#16279.
ptrxyz
pushed a commit
to ptrxyz/qmk_firmware
that referenced
this pull request
Apr 9, 2022
BorisTestov
pushed a commit
to BorisTestov/qmk_firmware
that referenced
this pull request
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While looking to add OLED suspend support, noticed that a LOT of feature suspend code is duplicated in
tmk_core/common/(platform)/suspend.c.Moves out that code into quantum.c to be a common location for easier management.
And added oled/st7565 suspend support, too.
I'm not sure I like dumping it in quantum.c, but ...
Types of Changes
Checklist