MechBrewery MB65S Refactor #15515
Merged
MechBrewery MB65S Refactor #15515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The layouts listed aren't actually supported because the PCB only supports 65% with Blocker layouts, and not Standard 65% layouts.
Renamed because the PCB does not support ISO Left Shift; only ANSI Left Shift is supported.
Resize the Left Shift to 2.25u.
Supported layouts: 65_ansi_blocker, 65_ansi_blocker_split_bs
- use four-space indent - update keymap block comments - update keycode grid alignment
Aligns inline comments.
Replaces `kbd67` with `the MB65S`.
The only rule present is `LTO_ENABLE = yes`, which is already present at keyboard level, so it's not needed here.
fauxpark
approved these changes
Dec 19, 2021
AnthonyNguyen168
approved these changes
Dec 19, 2021
|
Thank you. |
drashna
approved these changes
Dec 19, 2021
mattgauf
added a commit
to mattgauf/qmk_firmware
that referenced
this pull request
Dec 20, 2021
* master: (581 commits) Add Superlyra keyboard + group with Lyra under new directory (qmk#14955) MechBrewery MB65S Refactor (qmk#15515) [Keyboard] Add k34 keyboard (qmk#15250) [Keyboard] update new keyboard zoom65_lite (qmk#15218) [Keyboard] Add Borderland (qmk#15501) [Keyboard] Nasu (qmk#15468) [Keyboard] Remove locking support for Sweep (qmk#15494) [Keyboard] Remove locking support from Cradio (qmk#15495) [Keyboard] Remove locking support for Macro3 (qmk#15496) [Keyboard] Add WestM (qmk#15459) Fix inverted gt and lt send_string mapping in canadian multilingual (qmk#15487) [Keyboard] removed extra layout from jorne.h (qmk#15491) [Keyboard] Add Jorne (qmk#15461) Fix some wrong keycode macros in locale mapping files (qmk#15488) [Core] Fix Sensor driver code (qmk#15484) [Keymap] Unicode and Pointing Device and Autocorect for drashna keymaps (qmk#15415) [Keyboard] Adelie Firmware (qmk#13265) [Keyboard] Add Elite-C DFU bootloader commands for Sweep (qmk#15449) [Keyboard] W1-AT addition (qmk#15467) [Keyboard] Add swap hands support for Technik_O (qmk#15477) ...
epiciskandar
pushed a commit
to epiciskandar/qmk_firmware
that referenced
this pull request
Dec 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cleans up around the layout macros, which were misleading as to the supported layouts, and some minor keymap refactoring.
LAYOUT_65_ansi->LAYOUT_65_ansi_blockerLAYOUT_65_ansi_split_bs->LAYOUT_65_ansi_blocker_split_bsLAYOUT_65_iso->LAYOUT_65_ansi_blocker_isoenter(full ISO layouts aren't supported by the PCB)info.jsonrules.mkcc @AnthonyNguyen168 (keyboard maintainer)
Types of Changes
Checklist