Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Keyboard] Add Jorne #15461

Merged
merged 34 commits into from
Dec 16, 2021
Merged

[Keyboard] Add Jorne #15461

merged 34 commits into from
Dec 16, 2021

Conversation

joric
Copy link

@joric joric commented Dec 12, 2021

Description

Add Jorne Keyboard

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • Add Jorne Keyboard

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Dec 12, 2021
@joric
Copy link
Author

joric commented Dec 12, 2021

Jorne is essentially Corne but with an extra keys for brackets and international layouts (44 keys instead of 42).
It's not a Corne keymap anymore, I ported it to split_common (also because it needed hacking a matrix in the keymap file).
It got to the Amazing Keyboards and became pretty popular since 2019, maybe 100+ people using it on a regular basis.
There's Jorne wiki https://github.com/joric/jorne/wiki

drashna
drashna requested changes Dec 13, 2021
View reviewed changes
keyboards/jorne/keymaps/default/config.h Outdated Show resolved Hide resolved
keyboards/jorne/keymaps/default/config.h Outdated Show resolved Hide resolved
keyboards/jorne/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/jorne/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/jorne/readme.md Show resolved Hide resolved
keyboards/jorne/rev1/rev1.c Show resolved Hide resolved
keyboards/jorne/rules.mk Outdated Show resolved Hide resolved
keyboards/jorne/rules.mk Outdated Show resolved Hide resolved
@joric
Copy link
Author

joric commented Dec 13, 2021

@drashna thanks! All fixed.

@joric joric requested a review from drashna December 13, 2021 05:47
drashna
drashna reviewed Dec 13, 2021
View reviewed changes
keyboards/jorne/jorne.c Outdated Show resolved Hide resolved
@joric joric requested a review from drashna December 13, 2021 20:27
@drashna drashna requested a review from a team December 13, 2021 20:38
fauxpark
fauxpark requested changes Dec 14, 2021
View reviewed changes
keyboards/jorne/rules.mk Outdated Show resolved Hide resolved
keyboards/jorne/rev1/config.h Outdated Show resolved Hide resolved
keyboards/jorne/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/jorne/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/jorne/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/jorne/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/jorne/jorne.c Outdated Show resolved Hide resolved
keyboards/jorne/jorne.c Outdated Show resolved Hide resolved
@joric
Copy link
Author

joric commented Dec 14, 2021 •
edited
Loading

@fauxpark removed all unnecessary defines and rechecked the firmware, everything looks fine.

Added to qmk configurator here qmk/qmk_configurator#1032

@joric joric requested a review from fauxpark December 14, 2021 07:57
@tzarc tzarc merged commit 4255515 into qmk:master Dec 16, 2021
@joric joric mentioned this pull request Dec 16, 2021
Merged
@beta-tank beta-tank mentioned this pull request Dec 16, 2021
Merged
6 tasks
mattgauf added a commit to mattgauf/qmk_firmware that referenced this pull request Dec 20, 2021
@mattgauf
Merge branch 'master' into private/mattgauf-gmmk-pro
9e88eb5 
* master: (581 commits)
  Add Superlyra keyboard + group with Lyra under new directory (qmk#14955)
  MechBrewery MB65S Refactor (qmk#15515)
  [Keyboard] Add k34 keyboard (qmk#15250)
  [Keyboard] update new keyboard zoom65_lite (qmk#15218)
  [Keyboard] Add Borderland (qmk#15501)
  [Keyboard] Nasu (qmk#15468)
  [Keyboard] Remove locking support for Sweep (qmk#15494)
  [Keyboard] Remove locking support from Cradio (qmk#15495)
  [Keyboard] Remove locking support for Macro3 (qmk#15496)
  [Keyboard] Add WestM (qmk#15459)
  Fix inverted gt and lt send_string mapping in canadian multilingual (qmk#15487)
  [Keyboard] removed extra layout from jorne.h (qmk#15491)
  [Keyboard] Add Jorne (qmk#15461)
  Fix some wrong keycode macros in locale mapping files (qmk#15488)
  [Core] Fix Sensor driver code (qmk#15484)
  [Keymap] Unicode and Pointing Device and Autocorect for drashna keymaps (qmk#15415)
  [Keyboard] Adelie Firmware (qmk#13265)
  [Keyboard] Add Elite-C DFU bootloader commands for Sweep (qmk#15449)
  [Keyboard] W1-AT addition (qmk#15467)
  [Keyboard] Add swap hands support for Technik_O (qmk#15477)
  ...
epiciskandar pushed a commit to epiciskandar/qmk_firmware that referenced this pull request Dec 21, 2021
@joric @beta-tank
@drashna @fauxpark @epiciskandar
[Keyboard] Add Jorne (qmk#15461)
89960e2 
* added jorne-dev (kyria-based)

* updated files

* raw logo

* removed font

* Fix after rebase on master: #undef SH_TG

* Fix LTO parameter name.

* Fix OLED.

* Add VIA Jorne layout.

* readme.md

* updated jorne readme

* Add info.json

* Update keyboards/jorne/keymaps/default/config.h

Co-authored-by: Drashna Jaelre <[email protected]>

* Update keyboards/jorne/keymaps/default/config.h

Co-authored-by: Drashna Jaelre <[email protected]>

* Update keyboards/jorne/keymaps/default/keymap.c

Co-authored-by: Drashna Jaelre <[email protected]>

* Update keyboards/jorne/rules.mk

Co-authored-by: Drashna Jaelre <[email protected]>

* Update keyboards/jorne/rules.mk

Co-authored-by: Drashna Jaelre <[email protected]>

* PR changes (added GPL headers, moved oled_task_user)

* info.jsoon: fix thumbs poositions, reorder keys.

* fix info.json maintainer

* fixed layouts

* Sync config.h for VIA with default keymap.

* added post_config (sets brightness to 120 or it hangs)

* added SPLIT_LAYER_STATE_ENABLE/SPLIT_LED_STATE_ENABLE

* Update keyboards/jorne/rules.mk

Co-authored-by: Ryan <[email protected]>

* Update keyboards/jorne/rev1/config.h

Co-authored-by: Ryan <[email protected]>

* Update keyboards/jorne/keymaps/via/keymap.c

Co-authored-by: Ryan <[email protected]>

* Update keyboards/jorne/keymaps/default/keymap.c

Co-authored-by: Ryan <[email protected]>

* Update keyboards/jorne/jorne.c

Co-authored-by: Ryan <[email protected]>

* Update keyboards/jorne/jorne.c

Co-authored-by: Ryan <[email protected]>

* fixed layout, removed unnecessary defines

* vendor_id set to 0x4753

Co-authored-by: beta-tank <[email protected]>
Co-authored-by: Drashna Jaelre <[email protected]>
Co-authored-by: Ryan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

@drashna drashna drashna approved these changes

@fauxpark fauxpark Awaiting requested review from fauxpark

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@joric @drashna @tzarc @fauxpark @beta-tank