Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partially reinstate CI formatting process #15155

Merged
merged 3 commits into from
Nov 14, 2021

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Nov 14, 2021

Description

Puts back the dos2unix check, however keyboard PRs will need further work.

QOL improvement to flag which files are failing, rather than it be hidden in the log
image
(further iteration on the problem would be required to get accurate line numbers, error content, etc)

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr requested a review from a team November 14, 2021 22:06
@zvecr zvecr force-pushed the feature/format_dos2unix branch from abcb3d4 to ee95d53 Compare November 14, 2021 22:15
@github-actions github-actions bot removed the core label Nov 14, 2021
@zvecr zvecr merged commit ec0bb79 into qmk:master Nov 14, 2021
mgor pushed a commit to mgor/qmk_firmware that referenced this pull request Nov 16, 2021
* Partially reinstate CI formatting process

* Fix exit code on clean run

* Fix exit code on clean run
cadusk pushed a commit to cadusk/qmk_firmware that referenced this pull request Dec 2, 2021
* qmk/develop: (32 commits)
  [Keyboard] Add macro3 PCB support (qmk#15131)
  [Keyboard] Add layout options, hotswap version to portal 66 (qmk#14719)
  [Keyboard] Add Bourgeau 75% PCB (qmk#15072)
  [Keyboard] Fix bandominedoni via keymap compilation (qmk#15171)
  Fix additional board sizes for RGB Matrix (qmk#15170)
  kb_elmo/m0116_usb: Fix Configurator Key Sequence (qmk#15147)
  Require explicit enabling of RGB Matrix modes (qmk#15018)
  Reimplements WPM feature to be smaller & precise (qmk#13902)
  Add support for deferred executors. (qmk#14859)
  Add needed include to pointing_device.c (qmk#15167)
  Fix uart function prototypes (qmk#15162)
  Rework and expand Pointing Device support (qmk#14343)
  Partially reinstate CI formatting process (qmk#15155)
  kb_elmo/elmopad: fix macro reference in info.json (qmk#15142)
  kb_elmo/m0110a_usb: Fix Configurator Key Sequence (qmk#15143)
  Update UART driver API (qmk#14839)
  Fix hebrew emoji in langs.md (qmk#15140)
  [Keyboard] Add space between Cradio info.json layout (qmk#15127)
  add wait to unicode for win (qmk#15061)
  [Docs] Correct logic of tap hold statement (qmk#14992)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI cli qmk cli command python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants