Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Bourgeau 75% PCB. #15072

Merged
merged 3 commits into from
Nov 15, 2021
Merged

Add Bourgeau 75% PCB. #15072

merged 3 commits into from
Nov 15, 2021

Conversation

studiokestra
Copy link
Contributor

Description

Add QMK & VIA support for bourgeau 75% PCB, meant to be used in the PLA75 keyboard.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Nov 5, 2021
drashna
drashna requested changes Nov 6, 2021
View reviewed changes
keyboards/studiokestra/bourgeau/info.json Outdated Show resolved Hide resolved
keyboards/studiokestra/bourgeau/rules.mk Outdated Show resolved Hide resolved
keyboards/studiokestra/bourgeau/rules.mk Outdated Show resolved Hide resolved
@studiokestra
Adjusted info.json and rules.mk
6609556 
Revised bootmagic in rules.mk and removed deprecated items.
@studiokestra
Copy link
Contributor Author

Changes made as requested. Thanks @drashna !

drashna
drashna requested changes Nov 6, 2021
View reviewed changes
keyboards/studiokestra/bourgeau/config.h Outdated Show resolved Hide resolved
@studiokestra @drashna
Explicitly define RGB effects.
b7d947d 
Co-authored-by: Drashna Jaelre <[email protected]>
@studiokestra
Copy link
Contributor Author

I haven't explicitly defined RGB definitions in the past.
Is this part of the standard review moving forward or is it more of a preference thing?

@drashna
Copy link
Member

drashna commented Nov 6, 2021

I haven't explicitly defined RGB definitions in the past. Is this part of the standard review moving forward or is it more of a preference thing?

It's a newer thing, since we've had a number of animations added, and have had issues with a lot of boards compiling over size. By explicitly defining them means that this won't be a problem in the future.

(also, the define for all animations wasn't originally meant to enable all the modes)

@studiokestra
Copy link
Contributor Author

I haven't explicitly defined RGB definitions in the past. Is this part of the standard review moving forward or is it more of a preference thing?

It's a newer thing, since we've had a number of animations added, and have had issues with a lot of boards compiling over size. By explicitly defining them means that this won't be a problem in the future.

(also, the define for all animations wasn't originally meant to enable all the modes)

Makes sense, thanks for clarifying. Changes have been committed.

@studiokestra studiokestra requested a review from drashna November 11, 2021 22:22
@drashna drashna requested a review from a team November 15, 2021 17:00
@drashna
Copy link
Member

drashna commented Nov 15, 2021

Thanks!

@drashna drashna merged commit 269990e into qmk:master Nov 15, 2021
mgor pushed a commit to mgor/qmk_firmware that referenced this pull request Nov 16, 2021
@studiokestra @drashna @mgor
[Keyboard] Add Bourgeau 75% PCB (qmk#15072)
a1e1fc9 
Co-authored-by: Drashna Jaelre <[email protected]>
@studiokestra studiokestra mentioned this pull request Nov 20, 2021
Merged
6 tasks
cadusk pushed a commit to cadusk/qmk_firmware that referenced this pull request Dec 2, 2021
Merge remote-tracking branch 'qmk/develop' into develop
acb0226 
* qmk/develop: (32 commits)
  [Keyboard] Add macro3 PCB support (qmk#15131)
  [Keyboard] Add layout options, hotswap version to portal 66 (qmk#14719)
  [Keyboard] Add Bourgeau 75% PCB (qmk#15072)
  [Keyboard] Fix bandominedoni via keymap compilation (qmk#15171)
  Fix additional board sizes for RGB Matrix (qmk#15170)
  kb_elmo/m0116_usb: Fix Configurator Key Sequence (qmk#15147)
  Require explicit enabling of RGB Matrix modes (qmk#15018)
  Reimplements WPM feature to be smaller & precise (qmk#13902)
  Add support for deferred executors. (qmk#14859)
  Add needed include to pointing_device.c (qmk#15167)
  Fix uart function prototypes (qmk#15162)
  Rework and expand Pointing Device support (qmk#14343)
  Partially reinstate CI formatting process (qmk#15155)
  kb_elmo/elmopad: fix macro reference in info.json (qmk#15142)
  kb_elmo/m0110a_usb: Fix Configurator Key Sequence (qmk#15143)
  Update UART driver API (qmk#14839)
  Fix hebrew emoji in langs.md (qmk#15140)
  [Keyboard] Add space between Cradio info.json layout (qmk#15127)
  add wait to unicode for win (qmk#15061)
  [Docs] Correct logic of tap hold statement (qmk#14992)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@studiokestra @drashna @fauxpark