Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bm60hsrgb_poker/rev2, a continuation of #15001 #15103

Merged
merged 15 commits into from
Dec 25, 2021
Merged

Add bm60hsrgb_poker/rev2, a continuation of #15001 #15103

merged 15 commits into from
Dec 25, 2021

Conversation

peepeetee
Copy link
Contributor

@peepeetee peepeetee commented Nov 10, 2021 •
edited
Loading

After a discussion with @bdtc123, we decided to have me take over #15001, as his internet connection is spotty and I have too much time on my hands :P

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Nov 10, 2021
@peepeetee peepeetee marked this pull request as draft November 16, 2021 15:15
@peepeetee peepeetee force-pushed the bm60hsrgb_poker_rev2 branch from 6bcbca5 to feb4c19 Compare November 19, 2021 06:07
@peepeetee peepeetee marked this pull request as ready for review November 19, 2021 06:42
@peepeetee peepeetee changed the base branch from develop to master November 28, 2021 01:03
@peepeetee peepeetee requested a review from drashna November 28, 2021 16:23
@drashna drashna requested a review from a team November 28, 2021 18:00
@peepeetee peepeetee changed the title Add bm60hsrgb poker rev2, a continuation of #15001 Add bm60hsrgb_poker/rev2, a continuation of #15001 Dec 2, 2021
@peepeetee peepeetee mentioned this pull request Dec 6, 2021
Closed
fauxpark
fauxpark requested changes Dec 10, 2021
View reviewed changes
keyboards/kprepublic/bm60hsrgb_poker/readme.md Outdated Show resolved Hide resolved
keyboards/kprepublic/bm60hsrgb_poker/readme.md Outdated Show resolved Hide resolved
keyboards/kprepublic/bm60hsrgb_poker/rev2/config.h Outdated Show resolved Hide resolved
keyboards/kprepublic/bm60hsrgb_poker/rev2/config.h Outdated Show resolved Hide resolved
keyboards/kprepublic/bm60hsrgb_poker/rev2/rev2.c Outdated Show resolved Hide resolved
keyboards/kprepublic/bm60hsrgb_poker/rev2/rev2.c Outdated Show resolved Hide resolved
keyboards/kprepublic/bm60hsrgb_poker/rev2/rev2.c Outdated Show resolved Hide resolved
keyboards/kprepublic/bm60hsrgb_poker/rev2/rules.mk Outdated Show resolved Hide resolved
@peepeetee peepeetee force-pushed the bm60hsrgb_poker_rev2 branch from 6864831 to a8d8942 Compare December 11, 2021 11:55
@drashna drashna requested a review from a team December 11, 2021 18:43
@peepeetee peepeetee requested review from fauxpark and removed request for a team December 24, 2021 04:25
@drashna drashna merged commit 53996a7 into qmk:master Dec 25, 2021
@peepeetee peepeetee mentioned this pull request Jan 5, 2022
Closed
14 tasks
ryphon pushed a commit to ryphon/qmk_firmware that referenced this pull request Jan 12, 2022
@peepeetee @fauxpark @ryphon
[Keyboard] Add bm60hsrgb_poker/rev2, a continuation of qmk#15001 (qmk…
8f3d190 
…#15103)

Co-authored-by: Ryan <[email protected]>
@peepeetee peepeetee mentioned this pull request Feb 3, 2022
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@peepeetee @drashna @fauxpark