Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add KPrepublic BM60hsrgb_iso/rev2, acting in lieu of @bdtc123 #15095

Merged
merged 12 commits into from
Dec 25, 2021
Merged

Add KPrepublic BM60hsrgb_iso/rev2, acting in lieu of @bdtc123 #15095

merged 12 commits into from
Dec 25, 2021

Conversation

peepeetee
Copy link
Contributor

@peepeetee peepeetee commented Nov 9, 2021 •
edited
Loading

Description

I've been asked by @bdtc123 to upload their code to qmk, and this is one of the keyboards.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Nov 9, 2021
drashna
drashna requested changes Nov 10, 2021
View reviewed changes
keyboards/kprepublic/bm60v2_iso/bm60v2_iso.c Outdated Show resolved Hide resolved
keyboards/kprepublic/bm60v2_iso/config.h Outdated Show resolved Hide resolved
keyboards/kprepublic/bm60v2_iso/config.h Outdated Show resolved Hide resolved
keyboards/kprepublic/bm60v2_iso/info.json Outdated Show resolved Hide resolved
keyboards/kprepublic/bm60v2_iso/rules.mk Outdated Show resolved Hide resolved
keyboards/kprepublic/bm60v2_iso/rules.mk Outdated Show resolved Hide resolved
keyboards/kprepublic/bm60v2_iso/rules.mk Outdated Show resolved Hide resolved
@peepeetee peepeetee requested a review from drashna November 14, 2021 09:12
drashna
drashna requested changes Nov 15, 2021
View reviewed changes
keyboards/kprepublic/bm60v2_iso/bm60v2_iso.c Outdated Show resolved Hide resolved
keyboards/kprepublic/bm60v2_iso/config.h Outdated Show resolved Hide resolved
@peepeetee peepeetee changed the title Add KPrepublic BM60hsrgb/rev2, acting in lieu of @bdtc123 Add KPrepublic BM60hsrgb_iso/rev2, acting in lieu of @bdtc123 Nov 16, 2021
@peepeetee peepeetee marked this pull request as draft November 16, 2021 15:14
@peepeetee peepeetee marked this pull request as ready for review November 19, 2021 05:40
@peepeetee peepeetee requested a review from drashna November 19, 2021 05:40
@peepeetee peepeetee changed the base branch from develop to master November 28, 2021 01:03
@drashna drashna requested a review from a team November 28, 2021 06:07
@peepeetee peepeetee mentioned this pull request Dec 6, 2021
Closed
@peepeetee peepeetee requested a review from fauxpark December 7, 2021 09:25
fauxpark
fauxpark requested changes Dec 10, 2021
View reviewed changes
keyboards/kprepublic/bm60hsrgb_iso/rev2/config.h Outdated Show resolved Hide resolved
keyboards/kprepublic/bm60hsrgb_iso/rev2/rev2.h Outdated Show resolved Hide resolved
keyboards/kprepublic/bm60hsrgb_iso/rev2/rules.mk Outdated Show resolved Hide resolved
fauxpark
fauxpark requested changes Dec 10, 2021
View reviewed changes
keyboards/kprepublic/bm60hsrgb_iso/readme.md Show resolved Hide resolved
keyboards/kprepublic/bm60hsrgb_iso/rev2/config.h Outdated Show resolved Hide resolved
keyboards/kprepublic/bm60hsrgb_iso/rev2/config.h Outdated Show resolved Hide resolved
keyboards/kprepublic/bm60hsrgb_iso/rev2/rev2.c Outdated Show resolved Hide resolved
keyboards/kprepublic/bm60hsrgb_iso/rev2/rev2.c Outdated Show resolved Hide resolved
keyboards/kprepublic/bm60hsrgb_iso/rev2/rev2.c Outdated Show resolved Hide resolved
@peepeetee peepeetee requested a review from fauxpark December 24, 2021 04:25
@drashna drashna merged commit 34a7b43 into qmk:master Dec 25, 2021
ryphon pushed a commit to ryphon/qmk_firmware that referenced this pull request Jan 12, 2022
@peepeetee @fauxpark @ryphon
[Keyboard] Add KPrepublic BM60hsrgb_iso/rev2, acting in lieu of @bdtc123
6be424a 
 (qmk#15095)

Co-authored-by: Ryan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@peepeetee @drashna @fauxpark