Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
  • Loading branch information
peepeetee committed Dec 11, 2021
1 parent e9162b7 commit 7b79199
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 13 deletions.
1 change: 0 additions & 1 deletion keyboards/kprepublic/bm60hsrgb_iso/readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ Flashing example for this keyboard:
for rev1: make kprepublic/bm60hsrgb_iso/rev1:default:flash
for rev2: make kprepublic/bm60hsrgb_iso/rev2:default:flash


To check which board revision you have, check the PCB. If it has BM60v2-ISO printed on it, it's rev2. Otherwise it's rev1.

See the [build environment setup](https://docs.qmk.fm/#/getting_started_build_tools) and the [make instructions](https://docs.qmk.fm/#/getting_started_make_guide) for more information. Brand new to QMK? Start with our [Complete Newbs Guide](https://docs.qmk.fm/#/newbs).
5 changes: 0 additions & 5 deletions keyboards/kprepublic/bm60hsrgb_iso/rev2/config.h
Original file line number Diff line number Diff line change
Expand Up @@ -131,8 +131,6 @@
#define ENABLE_RGB_MATRIX_SOLID_SPLASH
#define ENABLE_RGB_MATRIX_SOLID_MULTISPLASH



// Note: The RGB LED driver configuration is not inside #ifdef blocks, so that
// the driver code would still compile even without RGBLIGHT_ENABLE and
// RGB_MATRIX_ENABLE (usually this is not required, but with the custom
Expand All @@ -143,9 +141,6 @@

#define RGB_MATRIX_MAXIMUM_BRIGHTNESS 180




// Underglow LEDs are WS2812, but someone might want to use RGBLIGHT for them;
// don't use those LEDs in RGB Matrix in that case.
#ifdef RGBLIGHT_ENABLE
Expand Down
7 changes: 0 additions & 7 deletions keyboards/kprepublic/bm60hsrgb_iso/rev2/rev2.c
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,6 @@

#ifdef RGB_MATRIX_ENABLE



# include "i2c_master.h"
# include "is31fl3733.h"
# include "ws2812.h"
Expand Down Expand Up @@ -140,9 +138,6 @@ void rgb_matrix_indicators_user(void) {
}
}




// clang-format on

// ==========================================================================
Expand Down Expand Up @@ -203,5 +198,3 @@ const rgb_matrix_driver_t rgb_matrix_driver = {
// clang-format on

#endif /* RGB_MATRIX_ENABLE */


0 comments on commit 7b79199

Please sign in to comment.