Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc followup 9942 #10473

Merged
merged 4 commits into from
Oct 1, 2020
Merged

Doc followup 9942 #10473

merged 4 commits into from
Oct 1, 2020

Conversation

nopunin10did
Copy link
Contributor

Description

Fill in missed bits of documentation for LSA, RSA, RCS, etc. (follow-up to issue #9942 & PR #9943).

These changes were originally in PR #10412, but I'm splitting them off into their own PR.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • 9942 is already closed, but this is a followup to that.

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@nopunin10did
Copy link
Contributor Author

@ridingqwerty , I broke out the documentation changes into their own PR.

@nopunin10did nopunin10did mentioned this pull request Sep 28, 2020
Closed
14 tasks
@zvecr zvecr merged commit 0cb7133 into qmk:master Oct 1, 2020
@zvecr
Copy link
Member

zvecr commented Oct 1, 2020

Thanks!

rgoulter pushed a commit to rgoulter/qmk_firmware that referenced this pull request Oct 4, 2020
@nopunin10did @rgoulter
Doc followup 9942 (qmk#10473)
1a5df9b 
* Update feature_advanced_keycodes.md

* Update mod_tap.md
kjganz pushed a commit to kjganz/qmk_firmware that referenced this pull request Oct 28, 2020
@nopunin10did
Doc followup 9942 (qmk#10473)
2cfd623 
* Update feature_advanced_keycodes.md

* Update mod_tap.md
@nopunin10did nopunin10did deleted the doc-followup-9942 branch November 10, 2022 14:44
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@nopunin10did
Doc followup 9942 (qmk#10473)
f5c51c0 
* Update feature_advanced_keycodes.md

* Update mod_tap.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

@ridingqwerty ridingqwerty ridingqwerty approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nopunin10did @zvecr @fauxpark @ridingqwerty