Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ethan605 keymap for kbd75 #10343

Merged
merged 8 commits into from
Sep 22, 2020
Merged

Add ethan605 keymap for kbd75 #10343

merged 8 commits into from
Sep 22, 2020

Conversation

ethan605
Copy link
Contributor

Description

Modified the default kbd75 keymap for more personal use.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@ethan605 ethan605 marked this pull request as ready for review September 17, 2020 14:57
drashna
drashna requested changes Sep 20, 2020
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And could you add license headers to the c and h files in this PR?

keyboards/kbdfans/kbd75/keymaps/ethan605/keymap.c Outdated Show resolved Hide resolved
keyboards/kbdfans/kbd75/keymaps/ethan605/keymap.c Outdated Show resolved Hide resolved
@drashna drashna requested a review from a team September 20, 2020 23:25
@drashna drashna added the keymap label Sep 20, 2020
@ethan605 ethan605 requested review from drashna and removed request for a team September 21, 2020 11:15
@drashna drashna requested a review from a team September 22, 2020 05:31
@noroadsleft noroadsleft merged commit 57dd756 into qmk:master Sep 22, 2020
@noroadsleft
Copy link
Member

Thanks!

@ethan605 ethan605 deleted the ethan605_kbd75_keymap branch September 30, 2020 16:49
rgoulter pushed a commit to rgoulter/qmk_firmware that referenced this pull request Oct 4, 2020
@ethan605 @rgoulter
[Keymap] Add ethan605 keymap for kbd75 (qmk#10343)
b2a1a2a 
* Add my KBD75 keymaps

* Acknowledge PR reviews

* Acknowledge PR reviews
kjganz pushed a commit to kjganz/qmk_firmware that referenced this pull request Oct 28, 2020
@ethan605
[Keymap] Add ethan605 keymap for kbd75 (qmk#10343)
80fbfcb 
* Add my KBD75 keymaps

* Acknowledge PR reviews

* Acknowledge PR reviews
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noroadsleft noroadsleft noroadsleft approved these changes

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ethan605 @noroadsleft @drashna @fauxpark