Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add keyboard 3dp660 #10296
Add keyboard 3dp660 #10296
Changes from 44 commits
e7512a3
b2a2d98
a73bc41
83e9ef4
1ebf9a5
caf8677
d260f8a
7afd44e
65c87cd
2ef1927
0c1c2f4
a764c49
ba0840e
0848dd2
4467b7f
20d4c4b
df18f70
aaf0b03
9021564
ca2c7b1
4312096
343c6af
3f45309
8f7f14c
f2bc6aa
e44edf6
b82fef9
33e0df5
cc536e1
0270824
c2e3f28
206e125
1e25c72
79736b6
7218c3b
7ff9bf9
e3fda39
fdf10a0
6c820a8
0830e4b
54a2f50
fd87cbc
5c5fe68
26c1681
3aa11b8
2d40001
3613799
a48da57
7ffa459
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What you could do here is set
LTO_ENABLE = yes
at keyboard level, and delete this file and remove LTO from the VIA keymap's rules.mk.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just followed along with merlin on a YT video, so I'm a little green on what you're talking about. What do you mean by "at keyboard level"? Where would I place the LTO line? In the rules.mk in main 3dp660 folder, not keymaps folder? Or somewhere else?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Basically, yes. Anything you set in the keyboard-level rules.mk is inherited by the keymap, unless you override it in the keymap's rules.mk. So you can put the LTO_ENABLE in the keyboard rules.mk, and it will be applied for both (all) keymaps.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Understood, thank you. I'll do that.