Add keyboard 3dp660 #10296

gooberpsycho · 2020-09-12T01:20:16Z

I followed MechMerlin's tutorials and wrote up the code for a handwired, 3d printed clueboard 660. The STL files are available on thingiverse at: https://www.thingiverse.com/thing:2897260. I have programmed it to use a Teensy 2.0 microcontroller. I also coded VIA support.

Description

Types of Changes

Issues Fixed or Closed by This PR

Checklist

My code follows the code style of this project: C, Python
I have read the PR Checklist document and have made the appropriate changes.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
I have tested the changes and verified that they work and don't break anything (as well as I can manage).

updating my fork to be up to date with master.

keyboards/handwired/3dp660/3dp660.h

keyboards/handwired/3dp660/3dp660.json

keyboards/handwired/3dp660/config.h

keyboards/handwired/3dp660/keymaps/default/keymap.c

keyboards/handwired/3dp660/keymaps/via/keymap.c

keyboards/handwired/3dp660/rules.mk

Removed Description line Co-authored-by: Drashna Jaelre <[email protected]>

remove extraneous default keymap layers Co-authored-by: Ryan <[email protected]>

Co-authored-by: Ryan <[email protected]>

fauxpark · 2020-09-23T01:10:03Z

keyboards/handwired/3dp660/keymaps/default/rules.mk

@@ -0,0 +1 @@
+LTO_ENABLE = YES


What you could do here is set LTO_ENABLE = yes at keyboard level, and delete this file and remove LTO from the VIA keymap's rules.mk.

I just followed along with merlin on a YT video, so I'm a little green on what you're talking about. What do you mean by "at keyboard level"? Where would I place the LTO line? In the rules.mk in main 3dp660 folder, not keymaps folder? Or somewhere else?

Basically, yes. Anything you set in the keyboard-level rules.mk is inherited by the keymap, unless you override it in the keymap's rules.mk. So you can put the LTO_ENABLE in the keyboard rules.mk, and it will be applied for both (all) keymaps.

Understood, thank you. I'll do that.

Moved LTO to keyboard level.

Made obsolete by LTO move to keyboard level.

keyboards/handwired/3dp660/rules.mk

capitalization errors. Co-authored-by: Ryan <[email protected]>

noroadsleft

GitHub tip: You can apply multiple suggestions to a single commit by using the Files Changed tab.

keyboards/handwired/3dp660/3dp660.h

keyboards/handwired/3dp660/info.json

keyboards/handwired/3dp660/keymaps/default/keymap.c

keyboards/handwired/3dp660/keymaps/via/keymap.c

keyboards/handwired/3dp660/readme.md

keyboards/handwired/3dp660/info.json

Housekeeping, changing code for readability. Co-authored-by: James Young <[email protected]>

noroadsleft · 2020-09-24T02:32:50Z

Thanks!

* Create keymap.c * Add files via upload * Added files for handwired 3d printed clueboard 660 * create via layout files * added layout files for via * updated product ID to fix id conflicts * change product ID to fix ID conflicts. * fixed capitalization error that was causing issues * fixed capitalization issues. * fix syntax errors * Fixed syntax errors (stray punctuation) * Compatibility fixes * Compatibility fixes * Compatibility fixes * Compatibility fixes * capitalization fixes * Compatibility fixes * Compatibility fixes * Compatibility Fixes * Compatibility fixes * Compatibility fixes * Compatibility changes * upkeep, fixing typos * Update keyboards/handwired/3dp660/config.h Removed Description line * Update keyboards/handwired/3dp660/rules.mk correct bootloader * Update keyboards/handwired/3dp660/3dp660.h fix case sensitive typos * Update keyboards/handwired/3dp660/keymaps/default/keymap.c change tab indentation to space indentations. * Update keyboards/handwired/3dp660/keymaps/via/keymap.c change tab indentations to space indentations * Delete 3dp660.json This file was for VIA, and shouldn't be in this repo. I placed it here so I wouldn't misplace it in my filesystem. My apologies. * Update info.json change suggestions to other file said to lowercase "ansi", caused reference issues, changed all instances of "ANSI" to "ansi". * Update keymap.c change suggestions to other file said to lowercase "ansi", caused reference issues, changed all instances of "ANSI" to "ansi". * Update keymap.c more capitalization fixes * Update keyboards/handwired/3dp660/readme.md shortened imgur url * Update keyboards/handwired/3dp660/rules.mk remove extraneous comments * Delete config.h * Update keyboards/handwired/3dp660/rules.mk * Update 3dp660.c add license headers to all .c and .h files * Update 3dp660.h added license header to all .c and .h files. * Update keymap.c added license header to all .c and .h files. * Update keymap.c added license header to all .c and .h files. * Update keyboards/handwired/3dp660/readme.md Add maintainer URL * Update keyboards/handwired/3dp660/keymaps/default/keymap.c remove extraneous default keymap layers * Update keyboards/handwired/3dp660/keymaps/default/rules.mk * Update rules.mk Moved LTO to keyboard level. * Update rules.mk Moved LTO to keyboard level. * Delete rules.mk Made obsolete by LTO move to keyboard level. * Update keyboards/handwired/3dp660/rules.mk capitalization errors. * Apply suggestions from code review Housekeeping, changing code for readability.

gooberpsycho added 23 commits September 11, 2020 19:26

Merge pull request #1 from qmk/master

e7512a3

updating my fork to be up to date with master.

Create keymap.c

b2a2d98

Add files via upload

a73bc41

Added files for handwired 3d printed clueboard 660

83e9ef4

create via layout files

1ebf9a5

added layout files for via

caf8677

updated product ID to fix id conflicts

d260f8a

change product ID to fix ID conflicts.

7afd44e

fixed capitalization error that was causing issues

65c87cd

fixed capitalization issues.

2ef1927

fix syntax errors

0c1c2f4

Fixed syntax errors (stray punctuation)

a764c49

Compatibility fixes

ba0840e

Compatibility fixes

0848dd2

Compatibility fixes

4467b7f

Compatibility fixes

20d4c4b

capitalization fixes

df18f70

Compatibility fixes

aaf0b03

Compatibility fixes

9021564

Compatibility Fixes

ca2c7b1

Compatibility fixes

4312096

Compatibility fixes

343c6af

Compatibility changes

3f45309

gooberpsycho changed the title ~~3dp660~~ Add keyboard 3dp660 Sep 12, 2020

upkeep, fixing typos

8f7f14c

gooberpsycho mentioned this pull request Sep 12, 2020

added keyboard 3dp660 the-via/keyboards#306

Merged

1 task

drashna requested changes Sep 21, 2020

View reviewed changes

drashna requested a review from a team September 21, 2020 02:46

drashna added the keyboard label Sep 21, 2020

Update keyboards/handwired/3dp660/config.h

f2bc6aa

Removed Description line Co-authored-by: Drashna Jaelre <[email protected]>

gooberpsycho and others added 2 commits September 22, 2020 20:44

Update keyboards/handwired/3dp660/keymaps/default/keymap.c

5c5fe68

remove extraneous default keymap layers Co-authored-by: Ryan <[email protected]>

Update keyboards/handwired/3dp660/keymaps/default/rules.mk

26c1681

Co-authored-by: Ryan <[email protected]>

fauxpark reviewed Sep 23, 2020

View reviewed changes

gooberpsycho added 3 commits September 22, 2020 21:29

Update rules.mk

3aa11b8

Moved LTO to keyboard level.

Update rules.mk

2d40001

Moved LTO to keyboard level.

Delete rules.mk

3613799

Made obsolete by LTO move to keyboard level.

fauxpark requested changes Sep 23, 2020

View reviewed changes

keyboards/handwired/3dp660/rules.mk Outdated Show resolved Hide resolved

Update keyboards/handwired/3dp660/rules.mk

a48da57

capitalization errors. Co-authored-by: Ryan <[email protected]>

fauxpark approved these changes Sep 23, 2020

View reviewed changes

noroadsleft requested changes Sep 23, 2020

View reviewed changes

Apply suggestions from code review

7ffa459

Housekeeping, changing code for readability. Co-authored-by: James Young <[email protected]>

noroadsleft approved these changes Sep 24, 2020

View reviewed changes

noroadsleft merged commit 30ffae2 into qmk:master Sep 24, 2020

gooberpsycho deleted the 3dp660 branch September 24, 2020 02:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add keyboard 3dp660 #10296

Add keyboard 3dp660 #10296

gooberpsycho commented Sep 12, 2020 •

edited

Loading

fauxpark Sep 23, 2020

gooberpsycho Sep 23, 2020

fauxpark Sep 23, 2020

gooberpsycho Sep 23, 2020

noroadsleft left a comment

noroadsleft commented Sep 24, 2020

Add keyboard 3dp660 #10296

Add keyboard 3dp660 #10296

Conversation

gooberpsycho commented Sep 12, 2020 • edited Loading

Description

Types of Changes

Issues Fixed or Closed by This PR

Checklist

fauxpark Sep 23, 2020

Choose a reason for hiding this comment

gooberpsycho Sep 23, 2020

Choose a reason for hiding this comment

fauxpark Sep 23, 2020

Choose a reason for hiding this comment

gooberpsycho Sep 23, 2020

Choose a reason for hiding this comment

noroadsleft left a comment

Choose a reason for hiding this comment

noroadsleft commented Sep 24, 2020

gooberpsycho commented Sep 12, 2020 •

edited

Loading