SameSite Config Option for Cookie #35
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Develop to master
Develop to master - fix CSRF errors on re-login
- Added config option `ckanext.csrf_filter.same_site` to set the cookie Samesite attribute.
- Added SameSite config to readme.
ThrawnCA
approved these changes
Jun 10, 2023
- Added config option for regex matching exlcusions to CSRF token checks.
Regex Rules to Exempt from Token Checks
ThrawnCA
reviewed
Jun 21, 2023
|
Hi @JVickery-TBS, Due to github cost cutting, they disable github actions on forked repo's. Can you enable github actions on your fork and retrigger a build so cicd pipeline can run letting us know if tests pass, etc. https://github.com/open-data/ckanext-csrf-filter/actions |
|
@duttonw Workflows enabled on our fork now. Did you want me to add on dispatch and on PR to the test yaml? |
ThrawnCA
reviewed
Aug 1, 2023
- Allow response generators to return and not be edited to insert any token.
Co-authored-by: Ian Ward <[email protected]>
…ream Allow Response Streaming from Generators
ThrawnCA
reviewed
Aug 27, 2023
|
Just splitting this up into multiple PRs now. |
|
And this one: #37 (includes the |
|
And finally this one: #38 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
ckanext.csrf_filter.same_siteconfig option which defaults to'None'and uses it in setting the token cookie. Asserts the allowed values of 'Strict', 'Lax', and 'None'This should solve the issue: #28