Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SameSite attribute to token cookies #28

Closed
ThrawnCA opened this issue Sep 23, 2022 · 3 comments
Closed

Add SameSite attribute to token cookies #28

ThrawnCA opened this issue Sep 23, 2022 · 3 comments

Comments

@ThrawnCA
Copy link
Contributor

For defence in depth, it would be best to configure the SameSite attribute on token cookies, so that they're harder to misuse across sites. SameSite=Strict should work.
@JVickery-TBS JVickery-TBS mentioned this issue Jun 9, 2023
Closed
@JVickery-TBS
Copy link
Contributor

Pull request to solve this issue is in now. Allows config option to set this value, but still defaults to 'None' as it did before.

@JVickery-TBS
Copy link
Contributor

#36

@ThrawnCA
Copy link
Contributor Author

Implemented in 1.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ThrawnCA @JVickery-TBS