Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin numpy<2 and scipy<1.14 #624

Merged
merged 3 commits into from
Jul 22, 2024
Merged

Pin numpy<2 and scipy<1.14 #624

merged 3 commits into from
Jul 22, 2024

Conversation

t-imamichi
Copy link
Collaborator

@t-imamichi t-imamichi commented Jul 22, 2024

Summary

Docplex does not support Numpy version 2 and qiskit-algorithms does not support Scipy 1.14.
So, this PR pin the numpy and scipy versions.

This also fixes a warning of sphinx related to INFINITY.

Details and comments

@t-imamichi t-imamichi added type: ci Related to CI changes stable backport potential The bug might be minimal and/or import enough to be port to stable labels Jul 22, 2024
@t-imamichi t-imamichi changed the title Pin numpy<2 Pin numpy<2 and scipy<1.14 Jul 22, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 10034586878

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 92.857%

Totals Coverage Status
Change from base Build 9128549330: -0.1%
Covered Lines: 4446
Relevant Lines: 4788

💛 - Coveralls

Copy link
Member

@woodsp-ibm woodsp-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me.

FYI I will note the failure around .H in algorithms for scipy 1.14 I fixed a while back in algorithms qiskit-community/qiskit-algorithms#184 but it has not yet been released.

@t-imamichi
Copy link
Collaborator Author

Thank you for the information, Steve. I made a PR to docplex. I hope it will be merged.
IBMDecisionOptimization/docplex#10

@mergify mergify bot merged commit dd2ba85 into qiskit-community:main Jul 22, 2024
18 checks passed
@t-imamichi t-imamichi deleted the numpy branch July 22, 2024 13:49
mergify bot pushed a commit that referenced this pull request Jul 22, 2024
* pin numpy<2

* pin scipy<1.14

* fix a docstring

(cherry picked from commit dd2ba85)
mergify bot added a commit that referenced this pull request Jul 22, 2024
* pin numpy<2

* pin scipy<1.14

* fix a docstring

(cherry picked from commit dd2ba85)

Co-authored-by: Takashi Imamichi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge priority: high stable backport potential The bug might be minimal and/or import enough to be port to stable type: ci Related to CI changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants