Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scipy 1.14 compatibility fix #184

Merged
merged 3 commits into from
Jul 6, 2024
Merged

Conversation

woodsp-ibm
Copy link
Member

@woodsp-ibm woodsp-ibm commented Jun 29, 2024

Summary

Fixes #182

Scipy 1.14 compatibility fix

Details and comments

Using .H from csr_matrix had been deprecated and has now been removed in scipy 1.14. This changes NumPyEigensolver, to use an alternative (and works with the prior scipy). This also ends up fixing CI which has been failing in nightly builds recently.

@woodsp-ibm woodsp-ibm added bug Something isn't working stable backport potential The bug might be minimal and/or import enough to be port to stable labels Jun 29, 2024
@woodsp-ibm woodsp-ibm requested review from Cryoris and ElePT as code owners June 29, 2024 13:27
@coveralls
Copy link

coveralls commented Jun 29, 2024

Pull Request Test Coverage Report for Build 9724576922

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.429%

Totals Coverage Status
Change from base Build 9466154331: 0.0%
Covered Lines: 6359
Relevant Lines: 7032

💛 - Coveralls

@woodsp-ibm
Copy link
Member Author

woodsp-ibm commented Jun 29, 2024

Note this is failing tests against unreleased qiskit main - see #181 for more info.

@woodsp-ibm woodsp-ibm changed the title Numpy 2.0 compatibility fix Scipy 1.14 compatibility fix Jul 1, 2024
@woodsp-ibm woodsp-ibm merged commit 3fb69b3 into qiskit-community:main Jul 6, 2024
17 of 19 checks passed
@woodsp-ibm woodsp-ibm deleted the numpy2fix branch July 6, 2024 12:49
mergify bot pushed a commit that referenced this pull request Jul 6, 2024
(cherry picked from commit 3fb69b3)
mergify bot added a commit that referenced this pull request Jul 6, 2024
mrossinek added a commit to mrossinek/qiskit-nature-pyscf that referenced this pull request Sep 4, 2024
This can be removed once `qiskit-algorithms` releases a new version
which includes the fix there [1].

[1]: qiskit-community/qiskit-algorithms#184
mrossinek added a commit to qiskit-community/qiskit-nature-pyscf that referenced this pull request Sep 4, 2024
* ci: update download-artifact action

* ci: update black

* ci: trigger

* meta: constrain scipy

This can be removed once `qiskit-algorithms` releases a new version
which includes the fix there [1].

[1]: qiskit-community/qiskit-algorithms#184

* ci: fix mismatched upload-artifact action version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working stable backport potential The bug might be minimal and/or import enough to be port to stable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI failing since scipy 1.14.0 released
2 participants