-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes deprecation warnings in tutorials 10, 11. Closes #574. #575
Fixes deprecation warnings in tutorials 10, 11. Closes #574. #575
Conversation
The failing checks are due to |
|
Pull Request Test Coverage Report for Build 7115332361
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
built the docs and ran the changed examples. All looks good to me @dthuerck
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM too! Thx!
FYI if you Click the blue Details
link of any job in list (you might need to show all checks), in the left pane towards the top is Summary
. Click that and scroll down the page and you will see a number of artifacts - documentation.zip
is the docs built by CI and in this case it just uses the tutorials as they are checked in since the goal of this check was to check the docs would build. Then there is a tutorials3.8.zip
and tutorials3.11.zip
. These checks run the tutorials ((under min and max Python versions supported) to check they run and the docs are built from them so this has all docs built and if tutorials are changed the place to check the output from CI.
I'll label this StableBackportPotential
since the docs can be republished at any time (and this is done off the current stable branch so needs backporting) if the PR is just about fixing docs.
* Fixes deprecation warnings in tutorials 10, 11. * Docstring for Gurobi Helper Function. * Fix style. --------- Co-authored-by: Steve Wood <[email protected]> (cherry picked from commit 36ad1a1)
…579) * Fixes deprecation warnings in tutorials 10, 11. * Docstring for Gurobi Helper Function. * Fix style. --------- Co-authored-by: Steve Wood <[email protected]> (cherry picked from commit 36ad1a1) Co-authored-by: Daniel Thuerck <[email protected]>
good to know, thanks @woodsp-ibm ! |
Summary
Closes #574.
Tutorials 10 and 11 displayed deprecation warnings related to drawing circuit and displaying models from Gurobipy.
Details and comments
style
argument. We useclifford
here to keep the images consistent with previous versions of this tutorial.gurobipy
deprecated theModel.display()
. A look into their documentation did not reveal a clear substitute - but export to an.lp
file comes pretty close. Hence, we're using temporary.lp
files to pretty-print Gurobi models.