Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes deprecation warnings in tutorials 10, 11. Closes #574. #575

Merged

Conversation

dthuerck
Copy link
Contributor

@dthuerck dthuerck commented Dec 6, 2023

Summary

Closes #574.

Tutorials 10 and 11 displayed deprecation warnings related to drawing circuit and displaying models from Gurobipy.

Details and comments

  1. Tutorial 10: Drawing circuit requires an explicit style argument. We use clifford here to keep the images consistent with previous versions of this tutorial.
  2. Tutorial 11: gurobipy deprecated the Model.display(). A look into their documentation did not reveal a clear substitute - but export to an .lp file comes pretty close. Hence, we're using temporary .lp files to pretty-print Gurobi models.

@CLAassistant
Copy link

CLAassistant commented Dec 6, 2023

CLA assistant check
All committers have signed the CLA.

@dthuerck
Copy link
Contributor Author

dthuerck commented Dec 6, 2023

The failing checks are due to gurobipy and should be fixed by #573.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7115332361

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.029%

Totals Coverage Status
Change from base Build 7115317477: 0.0%
Covered Lines: 4511
Relevant Lines: 4849

💛 - Coveralls

Copy link

@Sofranac-Boro Sofranac-Boro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

built the docs and ran the changed examples. All looks good to me @dthuerck

Copy link
Member

@woodsp-ibm woodsp-ibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too! Thx!

FYI if you Click the blue Details link of any job in list (you might need to show all checks), in the left pane towards the top is Summary. Click that and scroll down the page and you will see a number of artifacts - documentation.zip is the docs built by CI and in this case it just uses the tutorials as they are checked in since the goal of this check was to check the docs would build. Then there is a tutorials3.8.zip and tutorials3.11.zip. These checks run the tutorials ((under min and max Python versions supported) to check they run and the docs are built from them so this has all docs built and if tutorials are changed the place to check the output from CI.

I'll label this StableBackportPotential since the docs can be republished at any time (and this is done off the current stable branch so needs backporting) if the PR is just about fixing docs.

@woodsp-ibm woodsp-ibm added stable backport potential The bug might be minimal and/or import enough to be port to stable automerge labels Dec 8, 2023
@mergify mergify bot merged commit 36ad1a1 into qiskit-community:main Dec 8, 2023
17 checks passed
mergify bot pushed a commit that referenced this pull request Dec 8, 2023
* Fixes deprecation warnings in tutorials 10, 11.

* Docstring for Gurobi Helper Function.

* Fix style.

---------

Co-authored-by: Steve Wood <[email protected]>
(cherry picked from commit 36ad1a1)
mergify bot added a commit that referenced this pull request Dec 8, 2023
…579)

* Fixes deprecation warnings in tutorials 10, 11.

* Docstring for Gurobi Helper Function.

* Fix style.

---------

Co-authored-by: Steve Wood <[email protected]>
(cherry picked from commit 36ad1a1)

Co-authored-by: Daniel Thuerck <[email protected]>
@Sofranac-Boro
Copy link

LGTM too! Thx!

FYI if you Click the blue Details link of any job in list (you might need to show all checks), in the left pane towards the top is Summary. Click that and scroll down the page and you will see a number of artifacts - documentation.zip is the docs built by CI and in this case it just uses the tutorials as they are checked in since the goal of this check was to check the docs would build. Then there is a tutorials3.8.zip and tutorials3.11.zip. These checks run the tutorials ((under min and max Python versions supported) to check they run and the docs are built from them so this has all docs built and if tutorials are changed the place to check the output from CI.

I'll label this StableBackportPotential since the docs can be republished at any time (and this is done off the current stable branch so needs backporting) if the PR is just about fixing docs.

good to know, thanks @woodsp-ibm !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge stable backport potential The bug might be minimal and/or import enough to be port to stable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update tutorials to avoid deprecated messages
5 participants