Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mypy for gurobipy 11.0 #573

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Conversation

t-imamichi
Copy link
Collaborator

Summary

Scheduled CI fails due to the new gurobipy 11.0 released on Nov 28.
This PR fixes type annotations.

Details and comments

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7041803266

  • 33 of 35 (94.29%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.029%

Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit_optimization/translators/gurobipy.py 33 35 94.29%
Totals Coverage Status
Change from base Build 7002406044: 0.0%
Covered Lines: 4511
Relevant Lines: 4849

💛 - Coveralls

@t-imamichi t-imamichi added the stable backport potential The bug might be minimal and/or import enough to be port to stable label Nov 30, 2023
@dthuerck
Copy link
Contributor

Thanks!

@mergify mergify bot merged commit 2b5c37b into qiskit-community:main Dec 6, 2023
17 checks passed
mergify bot pushed a commit that referenced this pull request Dec 6, 2023
(cherry picked from commit 2b5c37b)
woodsp-ibm pushed a commit that referenced this pull request Dec 6, 2023
(cherry picked from commit 2b5c37b)

Co-authored-by: Takashi Imamichi <[email protected]>
@t-imamichi t-imamichi deleted the gurobipy11 branch December 7, 2023 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge stable backport potential The bug might be minimal and/or import enough to be port to stable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants