Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix level 1 meas with sampler #1474

Closed
wants to merge 2 commits into from
Closed

fix level 1 meas with sampler #1474

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0062df7
fix level 1 meas with sampler
dekelmeirom Oct 14, 2024
c546a87
Update experiment_data.py
dekelmeirom Oct 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion qiskit_experiments/framework/experiment_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1067,7 +1067,6 @@ def _add_result_data(self, result: Result, job_id: Optional[str] = None) -> None
# different parameter binds which is trivial because
# qiskit-experiments does not support parameter binding
# to pubs currently.
joined_data = joined_data[0]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I did some more testing and confirmed this change is good. We need to remove the comment above it as well since it was explaining this line. This line came from the way I added level 1 support to BackendSampler for testing. I need to update that as well.

We can fix the comment here and merge or not. I will work on the tests in #1473 and will remove the comment there if it is not removed here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have removed the comment :)

if joined_data.ndim == 1:
data["meas_return"] = "avg"
# TODO: we either need to track shots in the
Expand Down