fix level 1 meas with sampler #1474
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
relevant to PR #1470 |
wshanks
reviewed
Oct 14, 2024
| @@ -1067,7 +1067,6 @@ def _add_result_data(self, result: Result, job_id: Optional[str] = None) -> None | |||
| # different parameter binds which is trivial because | |||
| # qiskit-experiments does not support parameter binding | |||
| # to pubs currently. | |||
| joined_data = joined_data[0] | |||
There was a problem hiding this comment.
Thanks, I did some more testing and confirmed this change is good. We need to remove the comment above it as well since it was explaining this line. This line came from the way I added level 1 support to BackendSampler for testing. I need to update that as well.
We can fix the comment here and merge or not. I will work on the tests in #1473 and will remove the comment there if it is not removed here.
There was a problem hiding this comment.
I have removed the comment :)
Remove comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fix is relevant only to experiments with measurement level 1 using Sampler.
Tested on qiskit-monitoring experiments and works fine