Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove version pins on documentation dependencies #1375

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

wshanks
Copy link
Collaborator

@wshanks wshanks commented Jan 25, 2024

Some of the pinned versions have gotten old and are confusing pip's resolver as it tries to find versions of the unpinned dependencies which are compatible with the pinned dependencies. The issues that led to the versions being pinned should be resolved.

Some of the pinned versions have gotten old and are confusing pip's
resolver as it tries to find versions of the unpinned dependencies which
are compatible with the pinned dependencies. The issues that led to the
versions being pinned should be resolved.
@wshanks
Copy link
Collaborator Author

wshanks commented Jan 25, 2024

I organized the dependencies so it is easier to check for things. The obscures somewhat what pins were removed. The removed ones were:

jupyter-client, ipython, ipykernel -- all removed entirely since they were just pinned because new releases broke packages we actually depended on.

sphinx, qiskit-sphinx-theme -- removed the upper bound on these dependencies.

There are still bounds on black and pylint which we might remove or raise later.

@wshanks wshanks requested a review from coruscating January 25, 2024 23:24
Copy link
Collaborator

@coruscating coruscating left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The built docs still look good after removing the pins. Thanks for organizing the file!

@coruscating coruscating added this pull request to the merge queue Jan 26, 2024
Merged via the queue into qiskit-community:main with commit 2461683 Jan 26, 2024
11 checks passed
@wshanks wshanks deleted the sphinx7 branch January 26, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants