-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch tests and documentation to use qiskit-ibm-runtime fake backends #1369
Conversation
Note: this PR is marked as a draft because it requires currently unreleased qiskit-ibm-runtime code as noted in Qiskit/qiskit-ibm-runtime#1317. |
This PR will allow qiskit-experiments tests to keep working against Qiskit 0.45 and |
qiskit-ibm-runtime 0.18.0 has been released, so this change is usable now. However, currently, we uninstall qiskit-ibm-provider in our tests to run against Qiskit |
Rebased on #1375 which should be merged first (unrelated fix to unblock CI). |
b824f6f
to
5efeb4a
Compare
The IBM-specific fake backends in Qiskit are being removed in Qiskit 1.0 in Qiskit/qiskit#11376. The same fake backends have been moved to qiskit-ibm-runtime in Qiskit/qiskit-ibm-runtime#1140 and follow up PRs. Here the `qiskit` imports are replaced with `qiskit-ibm-runtime` imports in order to provide a smooth transition between Qiskit 0.45 and Qiskit 1.0. In the future, it may be preferable to use generic fake backends maintained in the repo and not depend on `qiskit-ibm-runtime` for them. Additionally, this commit reorders the requirements-dev.txt file so it is easier to read and adds qiskit-ibm-runtime as a development dependency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to be merged to make CI work again now that 0.46 has been released with a deprecation warning when using fake backends.
We have to keep an eye on the |
Oops, I removed all the place name backends but I didn't realize that |
We probably also need #1384? I didn't test my recent change locally. |
Ah, you're right. Do you want to rebase the changes in #1384 to this PR? They looked fine. |
I pinned qiskit here and then we can unpin it in #1384. |
4341be5
to
026f046
Compare
Hmm, my first pin didn't work...it annoys me how tox hides the output of pip explaining why it is installing what it is installing. I am not sure why qiskit 0.46 still got installed with my first attempt. |
The IBM-specific fake backends in Qiskit are being removed in Qiskit 1.0 in Qiskit/qiskit#11376. The same fake backends have been moved to qiskit-ibm-runtime in
Qiskit/qiskit-ibm-runtime#1140 and follow up PRs.
Here the
qiskit
imports are replaced withqiskit-ibm-runtime
imports in order to provide a smooth transition between Qiskit 0.45 and Qiskit 1.0. In the future, it may be preferable to use generic fake backends maintained in the repo and not depend onqiskit-ibm-runtime
for them.Additionally, this commit reorders the requirements-dev.txt file so it
is easier to read and adds qiskit-ibm-runtime as a development
dependency. It also temporarily pins qiskit to 0.45 while other
deprecations are addressed.